Do not cleanup processes on Mac due to no Orka VM isolation #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Leonard <[email protected]>
smlambert
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Approve with the note below.
We intend to look for a resolution with our Orka configuration but put this workaround in place in the meantime. While this may be specific to the Adoptium project and not other vendors who may be using this material, we know many vendors have Cleanup scripts that run separately to kill rogue processes and we did not previously have this script in place at all, so regressing functionality to that point.
sophia-guo
approved these changes
Jan 15, 2024
|
v1.0.0-release branch also needs this |
andrew-m-leonard
added a commit
to andrew-m-leonard/aqa-tests
that referenced
this pull request
Jan 16, 2024
…#4967) Signed-off-by: Andrew Leonard <[email protected]>
smlambert
pushed a commit
that referenced
this pull request
Jan 16, 2024
…4973) Signed-off-by: Andrew Leonard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orka x64 VMs do not seem to be process isolated, see: #4964
Which means currently the terminateProcess.sh pre&post test job will terminate any other test job processes that maybe visible on the Orka macstadium node that is being used.