Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Upgrade mui material try to fix pb with jest #2496

Merged

Conversation

xavierfacq
Copy link
Member

Description of change

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 9c21076
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/6586bda71479f90008e04f35
😎 Deploy Preview https://deploy-preview-2496--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e8ed18) 99.20% compared to head (9c21076) 99.20%.
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2496   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          87       87           
  Lines        6541     6541           
  Branches      552      552           
=======================================
  Hits         6489     6489           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierfacq
Copy link
Member Author

Ok this is not concluant - same error ...

@xavierfacq
Copy link
Member Author

Ok may be it's 👍

ReferenceError: jest is not defined
❯ Object. node_modules/jest-canvas-mock/lib/mock/createImageBitmap.js:9:16
❯ Module._compile node:internal/modules/cjs/loader:1376:14

from code :
let w = document.createElement("canvas").getContext("webgl");

@gdams
Copy link
Member

gdams commented Dec 17, 2023

The error is coming from vitest-canvas-mock (which in turn depends on jest-canvas-mock.

There is an open issue upstream to hopefully fix this

@xavierfacq
Copy link
Member Author

What I don't understand is why it works perfectly on my computer and it fails everytime in actions...
Maybe another think is the node & npm versions, I don't have the same. I continue my investigations 😄

@xavierfacq xavierfacq marked this pull request as ready for review December 23, 2023 11:04
@gdams gdams merged commit 4c67501 into adoptium:main Dec 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants