-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Masonry][Accessibility] aria-multiselectable incorrectly appears on coral-masonry element with role="row" #244
Labels
Comments
majornista
added a commit
to majornista/coral-spectrum
that referenced
this issue
Oct 6, 2022
…parent element with role="grid"
majornista
added a commit
to majornista/coral-spectrum
that referenced
this issue
Oct 11, 2022
…parent element with role="grid"
This is included in #250, so I will close this one. |
majornista
added a commit
that referenced
this issue
Nov 2, 2022
…) - Selected state of the folder is not announced to the screen reader (#250) * fix(#244): [Masonry][Accessibility] add aria-multiselectable to parent element with role="grid" * fix(#249): [Masonry][Accessibility] Files: Main Navigation (Card View) - Selected state of the folder is not announced to the screen reader
🎉 This issue has been resolved in version 4.15.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
With
ariaGrid="on"
, when theselectionMode
forcoral-masonry
is set to"single"
or"multiple"
,aria-multiselectable
should be added to theparentElement
of thecoral-masonry
element, which hasrole="grid"
, rather than thecoral-masonry
element itself, which hasrole="row"
.Actual Behavior
With
ariaGrid="on"
, when theselectionMode
forcoral-masonry
is set to"single"
or"multiple"
,aria-multiselectable
gets added to thecoral-masonry
element itself, which hasrole="row"
, instead of the appropriate parent element withrole="grid".
This will be identified by automated accessibility testing tools as an invalid use of WAI-ARIA. See https://www.w3.org/TR/wai-aria-1.1/#aria-multiselectable.Reproduce Scenario (including but not limited to)
https://opensource.adobe.com/coral-spectrum/examples/#masonry or any AEM UI using coral-masonry.
Steps to Reproduce
Browser name/version/os (ie Chrome Version 62.0.3202.94 (Official Build) (64-bit) MacOS)
Chrome Version 105.0.5195.125 (Official Build) (arm64) MacOS
Coral Spectrum version
v4.15.2
Sample Code that illustrates the problem (use the Playground if possible)
In the code below, one can see that
aria-multiselectable
attribute is being added directly to the coral-masonry element rather than its parent withrole="grid"
:coral-spectrum/coral-component-masonry/src/scripts/Masonry.js
Lines 224 to 239 in 6e967c1
Screenshots (if applicable)
The text was updated successfully, but these errors were encountered: