Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_historical_data() documentation #176

Open
rsheftel opened this issue Sep 30, 2019 · 2 comments
Open

get_historical_data() documentation #176

rsheftel opened this issue Sep 30, 2019 · 2 comments

Comments

@rsheftel
Copy link

The get_historical_data() function ( https://addisonlynch.github.io/iexfinance/stable/stocks.html#daily ) appears to return the adjusted data as defined in the IEX docs ( https://iexcloud.io/docs/api/#historical-prices ).

I would suggest in the function documentation to make clear that the returned values are the adjusted values.

I would also request an option to return the un-adjusted values as well because IEX only adjusts for splits and not dividends which is unusual and unexpected behavior.

@addisonlynch
Copy link
Owner

Thanks. Perhaps it would be better to return the unadjusted values by default given the unusual behavior you pointed out. I will also add a parameter (adjusted) to this function.

@rsheftel
Copy link
Author

It looks like in the new v0.5 release you now return the entire data provided by IEX including raw un-adjusted and adjusted data. You can close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants