Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LXML to version 5.1+ #477

Closed
adbar opened this issue Jan 16, 2024 · 1 comment · Fixed by #484
Closed

Update LXML to version 5.1+ #477

adbar opened this issue Jan 16, 2024 · 1 comment · Fixed by #484
Labels
dependencies Pull requests that update a dependency file

Comments

@adbar
Copy link
Owner

adbar commented Jan 16, 2024

This has to be thoroughly tested beforehand.
@adbar adbar added the dependencies Pull requests that update a dependency file label Jan 16, 2024
@adbar
Copy link
Owner Author

adbar commented Jan 16, 2024

There is a problem with _move_element_one_level_up in xml.py, probably due to a change in LXML v5.0:

  • LP#1976304: The Element.addnext() method previously inserted the new element
    before existing tail text. The tail text of both sibling elements now stays on
    the respective elements.

@adbar adbar linked a pull request Jan 23, 2024 that will close this issue
Handle changed behaviour of lxml addnext method #484
Merged
@adbar adbar mentioned this issue Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle changed behaviour of lxml addnext method knit-bee/trafilatura
1 participant
@adbar