Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added whereStartPlugin (fixes #29) #30

Closed
wants to merge 1 commit into from
Closed

New: Added whereStartPlugin (fixes #29) #30

wants to merge 1 commit into from

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 5, 2025 •
edited
Loading

fixes #29

New

  • Added whereStartPlugin(name, versionMask)

Notes

You should be able to

describe(name, async () => {
  whereStartPlugin(name, version)
})

But also

describe(name, async () => {
  mutateContent(name, async content => {
    if (whereStartPlugin(name, version)) {
      // assume default "" was added
    } else {
      // assume current value is set by user
    }
  })
  checkContent(name, async content => {
    if (whereStartPlugin(name, version)) {
      // assume default "" was added
    } else {
      // assume current value is set by user
    }
  })
})

@oliverfoster oliverfoster self-assigned this Feb 5, 2025
@joe-allen-89
Copy link
Contributor

As discussed previously I think adding whereStartPlugin is possibly overcomplicating the scripts and will potentially lead to differences in migrated courses. @oliverfoster I'm happy to close this for now but it is something we can keep an eye on moving forward.

@joe-allen-89 joe-allen-89 deleted the issue/29 branch February 13, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck Awaiting requested review from swashbuck

@joe-allen-89 joe-allen-89 Awaiting requested review from joe-allen-89

Assignees

@oliverfoster oliverfoster

Labels
enhancement
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow scripts to match the migration starting version
2 participants
@oliverfoster @joe-allen-89