Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Make sendState call async (Issue/134) #135

Merged
merged 14 commits into from
Jan 20, 2025
Merged

Fix: Make sendState call async (Issue/134) #135

merged 14 commits into from
Jan 20, 2025

Conversation

cahirodoherty-learningpool
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool commented Oct 25, 2024 •
edited
Loading

Fixes #134

Fix

  • Apply debounce around sendState calls to avoid concurrency issues

@cahirodoherty-learningpool cahirodoherty-learningpool marked this pull request as draft October 25, 2024 14:36
@swashbuck swashbuck added the bug label Dec 4, 2024
oliverfoster
oliverfoster reviewed Dec 17, 2024
View reviewed changes
js/XAPI.js Outdated Show resolved Hide resolved
oliverfoster
oliverfoster reviewed Dec 17, 2024
View reviewed changes
js/XAPI.js Outdated Show resolved Hide resolved
@cahirodoherty-learningpool cahirodoherty-learningpool marked this pull request as ready for review December 17, 2024 12:19
oliverfoster
oliverfoster reviewed Dec 17, 2024
View reviewed changes
js/XAPI.js Outdated Show resolved Hide resolved
oliverfoster
oliverfoster reviewed Dec 17, 2024
View reviewed changes
js/XAPI.js Outdated Show resolved Hide resolved
oliverfoster
oliverfoster approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@oliverfoster oliverfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does it work?

oliverfoster
oliverfoster reviewed Dec 17, 2024
View reviewed changes
js/XAPI.js Outdated Show resolved Hide resolved
@cahirodoherty-learningpool @oliverfoster
Update js/XAPI.js
8e82f98 
Co-authored-by: Oliver Foster <[email protected]>
@joe-allen-89 joe-allen-89 merged commit 0fe6ba0 into master Jan 20, 2025
github-actions bot pushed a commit that referenced this pull request Jan 20, 2025
@semantic-release-bot
Chore(release): 1.2.1 [skip ci]
cdd1fbf 
## [1.2.1](v1.2.0...v1.2.1) (2025-01-20)

### Fix

* Make sendState call async (fixes #134) (#135) ([0fe6ba0](0fe6ba0)), closes [#134](#134) [#135](#135)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@cahirodoherty-learningpool cahirodoherty-learningpool deleted the issue/134 branch January 20, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@ethan-lp ethan-lp Awaiting requested review from ethan-lp

@lemmyadams lemmyadams Awaiting requested review from lemmyadams

Assignees

@cahirodoherty-learningpool cahirodoherty-learningpool

Labels
bug ready to release released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sendState should behave asynchronously
4 participants
@cahirodoherty-learningpool @oliverfoster @swashbuck @joe-allen-89