Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_linkedId model values not correctly setup on scale #110

Closed
danielghost opened this issue May 21, 2024 · 1 comment · Fixed by #111
Closed

_linkedId model values not correctly setup on scale #110

danielghost opened this issue May 21, 2024 · 1 comment · Fixed by #111
Assignees
@danielghost
Labels
bug released

Comments

@danielghost
Copy link
Contributor

In addition to adaptlearning/adapt-contrib-slider#204, setupModelItems is called before _setupLinkedModel, meaning the scale can be incorrectly displayed because the range values from the linked model are not used when setting _items.
@danielghost danielghost self-assigned this May 21, 2024
@danielghost danielghost moved this from New to Assigned in adapt_framework: The TODO Board May 21, 2024
danielghost added a commit that referenced this issue May 21, 2024
@danielghost
Fix: linkedModel values not correctly setup on scale when inherited (…
64f9430 
…fixes #110).
@danielghost danielghost mentioned this issue May 21, 2024
Merged
@danielghost danielghost moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board May 21, 2024
kirsty-hames pushed a commit that referenced this issue May 30, 2024
@danielghost
Fix: linkedModel values not correctly setup on scale when inherited (…
2db8a0e 
…#111)

* Fix: `linkedModel` values not correctly setup on scale when inherited (fixes #110).

* Restrict `_scaleStep` to a positive number in the latest schema. Amended `_linkedToId` validity check.

* Changed _scaleEnd schema default from 1 to 10.
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board May 30, 2024
github-actions bot pushed a commit that referenced this issue May 30, 2024
@semantic-release-bot
Chore(release): 5.5.2 [skip ci]
7ee1dd8 
## [5.5.2](v5.5.1...v5.5.2) (2024-05-30)

### Fix

* `linkedModel` values not correctly setup on scale when inherited (#111) ([2db8a0e](2db8a0e)), closes [#111](#111) [#110](#110)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@danielghost