Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_assessmentId cannot be blank #81

Closed
swashbuck opened this issue Oct 2, 2023 · 0 comments · Fixed by #85
Closed

_assessmentId cannot be blank #81

swashbuck opened this issue Oct 2, 2023 · 0 comments · Fixed by #85
Assignees
@swashbuck
Labels
bug question

Comments

@swashbuck
Copy link
Contributor

Subject of the issue

In the schemas, the description for _assessmentId is:

This is the unique name of the assessment for which results should be displayed. If you only have one assessment you can leave this blank.

The last part about being able to leave it blank does not seem to be accurate. In my testing, you must always provide a value here.

The README.md description of _assessmentId does not make a similar claim.

Are the schemas inaccurate? Or is there a bug with the plugin code?

Your environment

  • Framework 5.31.23
  • Assessment Results 5.1.7
@swashbuck swashbuck moved this from New to Awaiting Response in adapt_framework: The TODO Board Oct 2, 2023
@swashbuck swashbuck mentioned this issue Oct 2, 2023
Closed
@swashbuck swashbuck self-assigned this May 15, 2024
@swashbuck swashbuck moved this from Awaiting Response to Assigned in adapt_framework: The TODO Board May 15, 2024
@swashbuck swashbuck mentioned this issue May 15, 2024
Merged
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board May 15, 2024
joe-allen-89 added a commit that referenced this issue May 29, 2024
@swashbuck @joe-allen-89
Fix: Clarify the behavior when _assessmentId is left blank (fixes #81) (
b27403f 
#85)

* Clarify the behavior when _assessmentId is left blank

* Add period at end of description

Co-authored-by: joe-allen-89 <[email protected]>

* Add period at end of description

Co-authored-by: joe-allen-89 <[email protected]>

---------

Co-authored-by: joe-allen-89 <[email protected]>
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board May 29, 2024
github-actions bot pushed a commit that referenced this issue May 29, 2024
@semantic-release-bot
Chore(release): 5.2.2 [skip ci]
9985bc0 
## [5.2.2](v5.2.1...v5.2.2) (2024-05-29)

### Fix

* Clarify the behavior when _assessmentId is left blank (fixes #81) (#85) ([b27403f](b27403f)), closes [#81](#81) [#85](#85)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
bug question
Projects
None yet
Milestone
No milestone
1 participant
@swashbuck