Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir 1.14.0 support #20

Closed
mward-sudo opened this issue Sep 5, 2022 · 3 comments · Fixed by #21
Closed

Elixir 1.14.0 support #20

mward-sudo opened this issue Sep 5, 2022 · 3 comments · Fixed by #21

Comments

@mward-sudo
Copy link
Contributor

mward-sudo commented Sep 5, 2022

Since upgrading to Elixir 1.14.0 from 1.13.4 the Elixir Test Explorer extension is failing (displaying ExUnitTest: Error in the UI) and is logging the following error:

Error: TypeError: Cannot read property '0' of null

This may be related to Issue #7

Versions:

Erlang 25.0.4
Elixir 1.14.0-otp-25

Output from mix test --trace --seed=0 --only=""

Excluding tags: [:test, :pending]
Including tags: [:""]


CaptainsLogTest [test/captains_log_test.exs]
  * test random_planet_class it always returns one of the letters: D, H, J, K, L, M, N, R, T, Y (excluded) [L#6]
  * test random_planet_class it will eventually return each of the letters at least once (excluded) [L#15]
  * test random_ship_registry_number start with "NCC-" (excluded) [L#33]
  * test random_ship_registry_number ends with a random integer between 1000 and 9999 (excluded) [L#38]
  * test random_stardate is a float (excluded) [L#57]
  * test random_stardate is equal to or greater than 41_000.0 (excluded) [L#62]
  * test random_stardate is less than 42_000.0 (excluded) [L#69]
  * test random_stardate consecutive calls return floats with different fractional parts (excluded) [L#76]
  * test random_stardate returns floats with fractional parts with more than one decimal place (excluded) [L#87]
  * test format_stardate returns a string (excluded) [L#100]
  * test format_stardate formats floats (excluded) [L#105]
  * test format_stardate rounds floats to one decimal place (excluded) [L#110]
  * test format_stardate does not accept integers (excluded) [L#115]
All tests have been excluded.

Finished in 0.05 seconds (0.00s async, 0.05s sync)
13 tests, 0 failures, 13 excluded

Randomized with seed 0
The --only option was given to "mix test" but no test was executed

For comparison, using Elixir 1.13.4-otp25, which works correctly:

Excluding tags: [:test, :pending]
Including tags: [:""]


CaptainsLogTest [test/captains_log_test.exs]
  * test random_planet_class it always returns one of the letters: D, H, J, K, L, M, N, R, T, Y (excluded) [L#6]
  * test random_planet_class it will eventually return each of the letters at least once (excluded) [L#15]
  * test random_ship_registry_number start with "NCC-" (excluded) [L#33]
  * test random_ship_registry_number ends with a random integer between 1000 and 9999 (excluded) [L#38]
  * test random_stardate is a float (excluded) [L#57]
  * test random_stardate is equal to or greater than 41_000.0 (excluded) [L#62]
  * test random_stardate is less than 42_000.0 (excluded) [L#69]
  * test random_stardate consecutive calls return floats with different fractional parts (excluded) [L#76]
  * test random_stardate returns floats with fractional parts with more than one decimal place (excluded) [L#87]
  * test format_stardate returns a string (excluded) [L#100]
  * test format_stardate formats floats (excluded) [L#105]
  * test format_stardate rounds floats to one decimal place (excluded) [L#110]
  * test format_stardate does not accept integers (excluded) [L#115]


Finished in 0.05 seconds (0.00s async, 0.05s sync)
13 tests, 0 failures, 13 excluded

Randomized with seed 0
The --only option was given to "mix test" but no test was executed

The only difference being that 1.14.0 includes the following line directly below the list of tests:

All tests have been excluded.

@adamzapasnik
Copy link
Owner

hi @mward-sudo
thanks for raising the issue, I'll fix it this week

Leaving a note to myself, this is the PR that introduces this change: https://github.com/elixir-lang/elixir/pull/11827/files

@mward-sudo
Copy link
Contributor Author

Any progress on this issue?

If you're struggling for time to fix this then I'd be willing to attempt a fix and PR if you can give me some pointers towards the code that requires modification.

mward-sudo added a commit to mward-sudo/vscode-elixir-test-explorer that referenced this issue Sep 13, 2022
@mward-sudo
Copy link
Contributor Author

mward-sudo commented Sep 13, 2022

I have submitted a simple pull request that removes the new offending line All tests have been excluded. from the output before continuing to parse as per the previous logic.

adamzapasnik pushed a commit that referenced this issue Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants