-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c++17 concepts with CPP_template for engine/*.{cpp,h} files #1812
c++17 concepts with CPP_template for engine/*.{cpp,h} files #1812
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1812 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01%
==========================================
Files 399 399
Lines 38199 38201 +2
Branches 4281 4281
==========================================
- Hits 34426 34424 -2
- Misses 2473 2479 +6
+ Partials 1300 1298 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much,
I have made some small remarks for myself which I will quickly address and then we can merge this. There remains no further work here for you @sebastian-wieczorek
9dc2786
to
c33b909
Compare
@sebastian-wieczorek
|
Conformance check passed ✅No test result changes. |
|
should I restore it? I thought this comment says I need to fix it but you did it, sorry for the confusion. |
Backport C++20 concepts in the src/engine subdirecotory to C++17 using macros from range-v3.