Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactorings in the query planning for property paths #1805

Merged
merged 4 commits into from
Feb 14, 2025

Several additional cleanups.

6edc8ab
Select commit
Loading
Failed to load commit list.
Merged

Minor refactorings in the query planning for property paths #1805

Several additional cleanups.
6edc8ab
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 14, 2025 in 0s

90.04% (+0.02%) compared to 1570033

View this Pull Request on Codecov

90.04% (+0.02%) compared to 1570033

Details

Codecov Report

Attention: Patch coverage is 52.94118% with 40 lines in your changes missing coverage. Please review.

Project coverage is 90.04%. Comparing base (1570033) to head (6edc8ab).

Files with missing lines Patch % Lines
src/engine/QueryPlanner.cpp 41.66% 19 Missing and 2 partials ⚠️
src/parser/PropertyPath.cpp 40.74% 13 Missing and 3 partials ⚠️
src/engine/CheckUsePatternTrick.cpp 0.00% 0 Missing and 1 partial ⚠️
src/parser/ParsedQuery.cpp 75.00% 0 Missing and 1 partial ⚠️
src/parser/PropertyPath.h 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1805      +/-   ##
==========================================
+ Coverage   90.02%   90.04%   +0.02%     
==========================================
  Files         396      396              
  Lines       37974    37967       -7     
  Branches     4262     4261       -1     
==========================================
+ Hits        34185    34187       +2     
+ Misses       2493     2487       -6     
+ Partials     1296     1293       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov