Minor refactorings in the query planning for property paths #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1805 +/- ##
==========================================
+ Coverage 90.02% 90.04% +0.02%
==========================================
Files 396 396
Lines 37974 37967 -7
Branches 4262 4261 -1
==========================================
+ Hits 34185 34187 +2
+ Misses 2493 2487 -6
+ Partials 1296 1293 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Johannes Kalmbach <[email protected]>
joka921
approved these changes
Feb 14, 2025
RobinTF
commented
Feb 14, 2025
| PropertyPath::Operation op) { | ||
| PropertyPath p(std::move(op)); | ||
| p._children = std::move(children); | ||
| const Operation op) { |
There was a problem hiding this comment.
Suggested change
| const Operation op) { | |
| const Operation& op) { |
There was a problem hiding this comment.
No, trivially copyable small types can be passed by value, the pointer is an overhead:)
The const is for the usage within the function:)
Conformance check passed ✅No test result changes. |
|
joka921
changed the title
PropertyPath related code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those include fixing smaller sonarcloud issues and addressing non-functional
TODOstatements in the code.