Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly display wildcard port #1796

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Feb 11, 2025

The log message that is printed as soon as a QLever server is started now also prints the correct port when using the wildcard port 0. This special port causes UNIX-like systems to pick an arbitrary free port.
For fixed ports nothing changes.

@sparql-conformance
Copy link

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (2fad765) to head (32e8df5).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/Server.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1796   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files         396      396           
  Lines       37928    37928           
  Branches     4262     4262           
=======================================
+ Hits        34156    34157    +1     
  Misses       2477     2477           
+ Partials     1295     1294    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

@joka921 joka921 merged commit 702339f into ad-freiburg:master Feb 12, 2025
23 of 24 checks passed
@RobinTF RobinTF deleted the better-port-display branch February 12, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants