Optimize several includes #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance check passed ✅No test result changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1781 +/- ##
==========================================
- Coverage 90.03% 90.03% -0.01%
==========================================
Files 395 395
Lines 37904 37904
Branches 4263 4263
==========================================
- Hits 34128 34125 -3
+ Misses 2479 2478 -1
- Partials 1297 1301 +4 ☔ View full report in Codecov by Sentry. |
|
joka921
pushed a commit
that referenced
this pull request
Feb 12, 2025
Follow-up to #1781, eliminates some dead code and optimizes includes again by moving the very expensive include of `RuntimeParameters.h` into the cpp files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused
#includedirectives, or move them from header files to the.cppfiles. This should reduce QLever's compile time by a significant amount, especially as the expensiveCTREheaders are included in less places.