Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c++17 concepts with CPP_template for engine/*.{cpp,h} files #1779

Merged

Conversation

sebastian-wieczorek
Copy link
Contributor

@sebastian-wieczorek sebastian-wieczorek commented Feb 7, 2025

Backport the (few) occurences of C++20 concepts in the src/engine subdirecotory to C++17 using macros from range-v3.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (a307781) to head (416852d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1779      +/-   ##
==========================================
+ Coverage   90.00%   90.04%   +0.03%     
==========================================
  Files         395      395              
  Lines       37838    37909      +71     
  Branches     4258     4264       +6     
==========================================
+ Hits        34055    34134      +79     
+ Misses       2484     2478       -6     
+ Partials     1299     1297       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Johannes Kalmbach <[email protected]>
@joka921 joka921 marked this pull request as ready for review February 10, 2025 07:58
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have given the anonymous namespace an explicit name (Sonarcloud correctly complains about anonymous namespaces in the header). As soon as the checks have run through I am going to merge this.

Signed-off-by: Johannes Kalmbach <[email protected]>
@sparql-conformance
Copy link

@joka921 joka921 merged commit caae483 into ad-freiburg:master Feb 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants