From 1b2ff88d02121fed8b4bc4c738f5e5682605d349 Mon Sep 17 00:00:00 2001
From: RobinTF <83676088+RobinTF@users.noreply.github.com>
Date: Mon, 3 Feb 2025 16:06:28 +0100
Subject: [PATCH] Add basic tests

---
 .../sparqlExpressions/ConvertToNumericExpression.cpp       | 3 ---
 test/SparqlAntlrParserTest.cpp                             | 7 +++++++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/engine/sparqlExpressions/ConvertToNumericExpression.cpp b/src/engine/sparqlExpressions/ConvertToNumericExpression.cpp
index e912f0a1ef..a6f7a6d291 100644
--- a/src/engine/sparqlExpressions/ConvertToNumericExpression.cpp
+++ b/src/engine/sparqlExpressions/ConvertToNumericExpression.cpp
@@ -5,9 +5,6 @@
 #include "engine/sparqlExpressions/NaryExpressionImpl.h"
 
 namespace sparqlExpression {
-namespace detail::string_expressions {
-class StrExpressionImpl;
-}
 namespace detail::to_numeric {
 
 // class that converts an input `int64_t`, `double` or `std::string`
diff --git a/test/SparqlAntlrParserTest.cpp b/test/SparqlAntlrParserTest.cpp
index 84a2f46f7a..a0e10d9b6f 100644
--- a/test/SparqlAntlrParserTest.cpp
+++ b/test/SparqlAntlrParserTest.cpp
@@ -1798,8 +1798,15 @@ TEST(SparqlParser, FunctionCall) {
                      matchUnary(&makeConvertToIntExpression));
   expectFunctionCall(absl::StrCat(xsd, "double>(?x)"),
                      matchUnary(&makeConvertToDoubleExpression));
+  expectFunctionCall(absl::StrCat(xsd, "float>(?x)"),
+                     matchUnary(&makeConvertToDoubleExpression));
   expectFunctionCall(absl::StrCat(xsd, "decimal>(?x)"),
                      matchUnary(&makeConvertToDecimalExpression));
+  expectFunctionCall(absl::StrCat(xsd, "boolean>(?x)"),
+                     matchUnary(&makeConvertToBooleanExpression));
+
+  expectFunctionCall(absl::StrCat(xsd, "string>(?x)"),
+                     matchUnary(&makeConvertToStringExpression));
 
   // Wrong number of arguments.
   expectFunctionCallFails(absl::StrCat(geof, "distance>(?a)"));