Backport concepts in util/parser module for C++17 (#1799)

Replace all C++20 concept usages in the `util/parser` module using v3-range macros and/or the custom made ones from `backport/concepts`.

src/backports/concepts.h

@@ -21,6 +21,13 @@
 // `QL_CONCEPT_OR_TYPENAME(arg)`: expands to `arg` in C++20 mode, and to
 // `typename` in C++17 mode. Example usage:
 //
+// `CPP_lambda(capture)(arg)(requires ...)`: Expands lambda to use
+//  `requires` in C++20 mode and `std::enable_if_t` in C++17 mode.
+//
+// `CPP_template_lambda(capture)(typenames...)(arg)(requires ...)`: Expands
+// lambda with (C++20) explicit gemplate parameters  to use
+//  `requires` in C++20 mode and `std::enable_if_t` in C++17 mode.
+//
 // Example usages:
 //
 // `QL_CONCEPT_OR_NOTHING(std::view) auto x = someFunction();`
@@ -31,6 +38,12 @@
 //
 // `template <QL_CONCEPT_OR_TYPENAME(ql::same_as<int>) T> void f(){...}`
 //
+// `auto myLambda = CPP_lambda(someCapture)(someArg)(requires
+// ranges::same_as<decltype(someArg), int>) {...}`
+//
+// `auto myLambda2 = CPP_lambda(someCapture)(typename F)(F arg)(requires
+// ranges::same_as<F, int>) {...}`
+//
 // NOTE: The macros are variadic to allow for commas in the argument, like in
 // the second example above.
 
@@ -48,6 +61,8 @@
 #define CPP_and_2_def CPP_and_2_def_sfinae
 #define CPP_variadic_template CPP_template_NO_DEFAULT_SFINAE
 #define CPP_member_def CPP_member_def_sfinae
+#define CPP_lambda CPP_lambda_sfinae
+#define CPP_template_lambda CPP_template_lambda_sfinae
 #else
 #define QL_CONCEPT_OR_NOTHING(...) __VA_ARGS__
 #define QL_CONCEPT_OR_TYPENAME(...) __VA_ARGS__
@@ -57,6 +72,8 @@
 #define CPP_and_2_def CPP_and
 #define CPP_variadic_template CPP_template
 #define CPP_member_def CPP_member
+#define CPP_lambda CPP_LAMBDA_20
+#define CPP_template_lambda CPP_TEMPLATE_LAMBDA_20
 #endif
 
 // The namespace `ql::concepts` includes concepts that are contained in the

src/backports/cppTemplate2.h

@@ -58,3 +58,47 @@
 
 #define CPP_member_def_sfinae \
   template <bool (&CPP_true_fn)(::concepts::detail::xNil)>
+
+#define CPP_LAMBDA_20(...) [__VA_ARGS__] CPP_LAMBDA_ARGS
+
+#define CPP_TEMPLATE_LAMBDA_20(...) [__VA_ARGS__] CPP_TEMPLATE_LAMBDA_ARGS
+
+// The internals of the `CPP_lambda` template
+#define CPP_LAMBDA_SFINAE_ARGS(...) \
+(__VA_ARGS__ CPP_LAMBDA_SFINAE_AUX_
+
+#define CPP_LAMBDA_SFINAE_AUX_WHICH_(FIRST, ...) \
+  CPP_PP_EVAL(CPP_PP_CHECK, CPP_PP_CAT(CPP_LAMBDA_SFINAE_PROBE_CONCEPT_, FIRST))
+
+#define CPP_LAMBDA_SFINAE_AUX_(...)                       \
+  CPP_PP_CAT(CPP_LAMBDA_SFINAE_AUX_,                      \
+             CPP_LAMBDA_SFINAE_AUX_WHICH_(__VA_ARGS__, )) \
+  (__VA_ARGS__)
+
+#define CPP_LAMBDA_SFINAE_AUX_0(...) ,                           \
+std::enable_if_t<                                            \
+CPP_PP_CAT(CPP_LAMBDA_SFINAE_AUX_3_, __VA_ARGS__)        \
+>* = nullptr)
+
+#define CPP_lambda_sfinae(...)     \
+  CPP_PP_IGNORE_CXX2A_COMPAT_BEGIN \
+  [__VA_ARGS__] CPP_LAMBDA_SFINAE_ARGS
+
+#define CPP_TEMPLATE_LAMBDA_ARGS_sfinae(...) \
+  <__VA_ARGS__> CPP_LAMBDA_SFINAE_ARGS
+
+#define CPP_template_lambda_sfinae(...) \
+  [__VA_ARGS__] CPP_TEMPLATE_LAMBDA_ARGS_sfinae
+
+#define CPP_LAMBDA_SFINAE_AUX_3_requires
+
+#define CPP_LAMBDA_ARGS(...) (__VA_ARGS__) CPP_LAMBDA_AUX_
+
+#define CPP_LAMBDA_AUX_(...) \
+  CPP_PP_CAT(CPP_LAMBDA_AUX_, CPP_LAMBDA_AUX_WHICH_(__VA_ARGS__, ))(__VA_ARGS__)
+
+#define CPP_LAMBDA_AUX_WHICH_(FIRST, ...) CPP_PP_EVAL(CPP_PP_CHECK, FIRST)
+
+#define CPP_LAMBDA_AUX_0(...) __VA_ARGS__
+
+#define CPP_TEMPLATE_LAMBDA_ARGS(...) <__VA_ARGS__> CPP_LAMBDA_ARGS

src/parser/GeoPoint.h

@@ -40,8 +40,9 @@ class GeoPoint {
  public:
   using T = uint64_t;
 
-  template <typename H>
-  friend H AbslHashValue(H h, const std::same_as<GeoPoint> auto& g) {
+  CPP_template(typename H,
+               typename G)(requires std::same_as<G, GeoPoint>) friend H
+      AbslHashValue(H h, const G& g) {
     return H::combine(std::move(h), g.lat_, g.lng_);
   }
 

src/parser/Iri.h

@@ -7,6 +7,7 @@
 
 #include <string_view>
 
+#include "backports/concepts.h"
 #include "parser/NormalizedString.h"
 
 namespace ad_utility::triple_component {
@@ -30,8 +31,8 @@ class Iri {
  public:
   // A default constructed IRI is empty.
   Iri() = default;
-  template <typename H>
-  friend H AbslHashValue(H h, const std::same_as<Iri> auto& iri) {
+  CPP_template(typename H, typename I)(requires std::same_as<I, Iri>) friend H
+      AbslHashValue(H h, const I& iri) {
     return H::combine(std::move(h), iri.iri_);
   }
   bool operator==(const Iri&) const = default;

src/parser/Literal.h

@@ -7,6 +7,7 @@
 #include <optional>
 #include <variant>
 
+#include "backports/concepts.h"
 #include "parser/Iri.h"
 #include "parser/NormalizedString.h"
 
@@ -41,8 +42,9 @@ class Literal {
   }
 
  public:
-  template <typename H>
-  friend H AbslHashValue(H h, const std::same_as<Literal> auto& literal) {
+  CPP_template(typename H,
+               typename L)(requires std::same_as<L, Literal>) friend H
+      AbslHashValue(H h, const L& literal) {
     return H::combine(std::move(h), literal.content_);
   }
   bool operator==(const Literal&) const = default;

src/parser/LiteralOrIri.h

@@ -50,9 +50,9 @@ class alignas(16) LiteralOrIri {
       return LiteralOrIri{Iri::fromStringRepresentation(std::move(internal))};
     }
   }
-  template <typename H>
-  friend H AbslHashValue(H h,
-                         const std::same_as<LiteralOrIri> auto& literalOrIri) {
+  CPP_template(typename H,
+               typename L)(requires std::same_as<L, LiteralOrIri>) friend H
+      AbslHashValue(H h, const L& literalOrIri) {
     return H::combine(std::move(h), literalOrIri.data_);
   }
   bool operator==(const LiteralOrIri&) const = default;

src/parser/ParallelParseBuffer.h

@@ -15,6 +15,16 @@ using std::array;
 using std::string;
 using std::vector;
 
+namespace ad_utility::detail {
+
+template <typename Parser>
+CPP_requires(ParserGetBatchRequires, requires(Parser& p)(p.getBatch()));
+
+template <typename Parser>
+CPP_concept ParserGetBatch = CPP_requires_ref(ParserGetBatchRequires, Parser);
+
+}  // namespace ad_utility::detail
+
 /**
  * A wrapper to make the different Parsers interfaces compatible with the
  * parallel pipeline
@@ -57,11 +67,9 @@ class ParserBatcher {
     }
   }
 
-  // The second requires evaluates to `true` only if the `Parser` type has a
-  // getBatch() member function. The first requires enables this function only
-  // if the second "requires" evaluates to true
-  std::optional<std::vector<TurtleTriple>> getBatch()
-      requires requires(Parser& p) { p.getBatch(); } {
+  CPP_member auto getBatch()
+      -> CPP_ret(std::optional<std::vector<TurtleTriple>>)(
+          requires ad_utility::detail::ParserGetBatch<Parser>) {
     if (m_numTriplesAlreadyParsed >= m_maxNumTriples) {
       return std::nullopt;
     }

src/parser/RdfParser.h

@@ -459,8 +459,9 @@ class NQuadParser : public TurtleParser<Tokenizer_T> {
  * Parses turtle from std::string. Used to perform unit tests for
  * the different parser rules
  */
-template <std::derived_from<RdfParserBase> Parser>
-class RdfStringParser : public Parser {
+CPP_template(typename Parser)(
+    requires std::derived_from<Parser, RdfParserBase>) class RdfStringParser
+    : public Parser {
  public:
   using Parser::getLine;
   using Parser::prefixMap_;

src/parser/TokenizerCtre.h

@@ -336,6 +336,7 @@ class TokenizerCtre : public SkipWhitespaceAndCommentsMixin<TokenizerCtre> {
    * <true, matchContent> on success and <false, emptyStringView> on failure
    */
   struct Matcher {
+    // TODO<C++17, joka921>: Template-value feature not available in C++17
     template <auto& regex>
     static std::pair<bool, std::string_view> process(
         std::string_view data) noexcept {

src/parser/TripleComponent.h

@@ -22,6 +22,17 @@
 #include "util/Exception.h"
 #include "util/Forward.h"
 
+namespace ad_utility::detail {
+
+template <typename T, typename U>
+CPP_requires(MoveAssignableWithRequires, requires(T t, U&& u)(t = u));
+
+template <typename T, typename U>
+CPP_concept MoveAssignableWith =
+    CPP_requires_ref(MoveAssignableWithRequires, T, U);
+
+}  // namespace ad_utility::detail
+
 /// A wrapper around a `std::variant` that can hold the different types that the
 /// subject, predicate, or object of a triple can have in the Turtle Parser.
 /// Those currently are `double` (xsd:double and xsd:decimal), `int64_t`
@@ -56,10 +67,11 @@ class TripleComponent {
   TripleComponent() = default;
   /// Construct from anything that is able to construct the underlying
   /// `Variant`.
-  template <typename FirstArg, typename... Args>
-  requires(!std::same_as<std::remove_cvref_t<FirstArg>, TripleComponent> &&
-           std::is_constructible_v<Variant, FirstArg &&, Args && ...>)
-  TripleComponent(FirstArg&& firstArg, Args&&... args)
+  CPP_template(typename FirstArg, typename... Args)(
+      requires CPP_NOT(
+          std::same_as<std::remove_cvref_t<FirstArg>, TripleComponent>) &&
+      std::is_constructible_v<Variant, FirstArg&&, Args&&...>)
+      TripleComponent(FirstArg&& firstArg, Args&&... args)
       : _variant(AD_FWD(firstArg), AD_FWD(args)...) {
     if (isString()) {
       // Storing variables and literals as strings is deprecated. The following
@@ -83,9 +95,9 @@ class TripleComponent {
 
   /// Assignment for types that can be directly assigned to the underlying
   /// variant.
-  template <typename T>
-  requires requires(Variant v, T&& t) { _variant = t; }
-  TripleComponent& operator=(T&& value) {
+  CPP_template(typename T)(requires std::is_assignable_v<Variant, T&&>)
+      TripleComponent&
+      operator=(T&& value) {
     _variant = AD_FWD(value);
     checkThatStringIsValid();
     return *this;
@@ -103,10 +115,11 @@ class TripleComponent {
   TripleComponent& operator=(TripleComponent&&) = default;
 
   /// Make a `TripleComponent` directly comparable to the underlying types.
-  template <typename T>
-  requires requires(T&& t) { _variant == t; }
-  bool operator==(const T& other) const {
-    return _variant == other;
+  CPP_template(typename T)(
+      requires ad_utility::SameAsAnyTypeIn<T, Variant>) bool
+  operator==(const T& other) const {
+    auto ptr = std::get_if<T>(&_variant);
+    return ptr && *ptr == other;
   }
 
   /// Equality comparison between two `TripleComponent`s.
@@ -117,8 +130,9 @@ class TripleComponent {
   /// overload would also be eligible for the contained types that are
   /// implicitly convertible to `TripleComponent` which would lead to strange
   /// bugs.
-  template <typename H>
-  friend H AbslHashValue(H h, const std::same_as<TripleComponent> auto& tc) {
+  CPP_template(typename H,
+               typename TC)(requires std::same_as<TC, TripleComponent>) friend H
+      AbslHashValue(H h, const TC& tc) {
     return H::combine(std::move(h), tc._variant);
   }
 

src/parser/sparqlParser/SparqlQleverVisitor.cpp

@@ -7,7 +7,6 @@
 
 #include "parser/sparqlParser/SparqlQleverVisitor.h"
 
-#include <absl/strings/str_join.h>
 #include <absl/strings/str_split.h>
 
 #include <string>
@@ -2308,20 +2307,22 @@ ExpressionPtr Visitor::visit([[maybe_unused]] Parser::BuiltInCallContext* ctx) {
   using namespace sparqlExpression;
   // Create the expression using the matching factory function from
   // `NaryExpression.h`.
-  auto createUnary = [&argList]<typename Function>(Function function)
-      requires std::is_invocable_r_v<ExpressionPtr, Function, ExpressionPtr> {
+  auto createUnary = CPP_template_lambda(&argList)(typename F)(F function)(
+      requires std::is_invocable_r_v<ExpressionPtr, F, ExpressionPtr>) {
     AD_CORRECTNESS_CHECK(argList.size() == 1, argList.size());
     return function(std::move(argList[0]));
   };
-  auto createBinary = [&argList]<typename Function>(Function function)
-      requires std::is_invocable_r_v<ExpressionPtr, Function, ExpressionPtr,
-                                     ExpressionPtr> {
+
+  auto createBinary = CPP_template_lambda(&argList)(typename F)(F function)(
+      requires std::is_invocable_r_v<ExpressionPtr, F, ExpressionPtr,
+                                     ExpressionPtr>) {
     AD_CORRECTNESS_CHECK(argList.size() == 2);
     return function(std::move(argList[0]), std::move(argList[1]));
   };
-  auto createTernary = [&argList]<typename Function>(Function function)
-      requires std::is_invocable_r_v<ExpressionPtr, Function, ExpressionPtr,
-                                     ExpressionPtr, ExpressionPtr> {
+
+  auto createTernary = CPP_template_lambda(&argList)(typename F)(F function)(
+      requires std::is_invocable_r_v<ExpressionPtr, F, ExpressionPtr,
+                                     ExpressionPtr, ExpressionPtr>) {
     AD_CORRECTNESS_CHECK(argList.size() == 3);
     return function(std::move(argList[0]), std::move(argList[1]),
                     std::move(argList[2]));
@@ -2475,9 +2476,11 @@ SparqlExpression::Ptr Visitor::visit(Parser::StrReplaceExpressionContext* ctx) {
     reportError(
         ctx,
         "REPLACE expressions with four arguments (including regex flags) are "
-        "currently not supported by QLever. You can however incorporate flags "
+        "currently not supported by QLever. You can however incorporate "
+        "flags "
         "directly into a regex by prepending `(?<flags>)` to your regex. For "
-        "example `(?i)[ei]` will match the regex `[ei]` in a case-insensitive "
+        "example `(?i)[ei]` will match the regex `[ei]` in a "
+        "case-insensitive "
         "way.");
   }
   return sparqlExpression::makeReplaceExpression(std::move(children.at(0)),
@@ -2535,8 +2538,8 @@ ExpressionPtr Visitor::visit(Parser::AggregateContext* ctx) {
     std::string separator;
     if (ctx->string()) {
       // TODO: The string rule also allow triple quoted strings with different
-      //  escaping rules. These are currently not handled. They should be parsed
-      //  into a typesafe format with a unique representation.
+      //  escaping rules. These are currently not handled. They should be
+      //  parsed into a typesafe format with a unique representation.
       separator = visit(ctx->string()).get();
       // If there was a separator, we have to strip the quotation marks
       AD_CONTRACT_CHECK(separator.size() >= 2);
@@ -2652,19 +2655,20 @@ GraphTerm Visitor::visit(Parser::BlankNodeContext* ctx) {
 }
 
 // ____________________________________________________________________________________
-template <typename Ctx>
-void Visitor::visitVector(const std::vector<Ctx*>& childContexts)
-    requires voidWhenVisited<Visitor, Ctx> {
+CPP_template_def(typename Ctx)(
+    requires Visitor::voidWhenVisited<Visitor, Ctx>) void Visitor::
+    visitVector(const vector<Ctx*>& childContexts) {
   for (const auto& child : childContexts) {
     visit(child);
   }
 }
 
 // ____________________________________________________________________________________
-template <typename Ctx>
-[[nodiscard]] auto Visitor::visitVector(const std::vector<Ctx*>& childContexts)
-    -> std::vector<decltype(visit(childContexts[0]))>
-    requires(!voidWhenVisited<Visitor, Ctx>) {
+CPP_template_def(typename Ctx)(
+    requires CPP_NOT(Visitor::voidWhenVisited<Visitor, Ctx>))
+    [[nodiscard]] auto Visitor::visitVector(
+        const std::vector<Ctx*>& childContexts)
+        -> std::vector<decltype(visit(childContexts[0]))> {
   std::vector<decltype(visit(childContexts[0]))> children;
   for (const auto& child : childContexts) {
     children.emplace_back(visit(child));
@@ -2681,7 +2685,8 @@ Out Visitor::visitAlternative(Contexts*... ctxs) {
     (..., visitIf(ctxs));
   } else {
     std::optional<Out> out;
-    // Visit the one `context` which is not null and write the result to `out`.
+    // Visit the one `context` which is not null and write the result to
+    // `out`.
     (..., visitIf<std::optional<Out>, Out>(&out, ctxs));
     return std::move(out.value());
   }
@@ -2706,8 +2711,8 @@ void Visitor::visitIf(Target* target, Ctx* ctx) {
 }
 
 // _____________________________________________________________________________
-template <typename Ctx>
-void Visitor::visitIf(Ctx* ctx) requires voidWhenVisited<Visitor, Ctx> {
+CPP_template_def(typename Ctx)(requires Visitor::voidWhenVisited<
+                               Visitor, Ctx>) void Visitor::visitIf(Ctx* ctx) {
   if (ctx) {
     visit(ctx);
   }