From 1c40c90f27f96db4fddb43eaa8c8f44ba5b85dff Mon Sep 17 00:00:00 2001 From: cvarni Date: Wed, 2 Oct 2024 11:25:03 +0200 Subject: [PATCH] resolve sonar warnings --- Core/include/Acts/Clusterization/Clusterization.hpp | 7 ++++++- Core/include/Acts/Clusterization/TimedClusterization.hpp | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Core/include/Acts/Clusterization/Clusterization.hpp b/Core/include/Acts/Clusterization/Clusterization.hpp index 839cc3d4daa..497f862cd1f 100644 --- a/Core/include/Acts/Clusterization/Clusterization.hpp +++ b/Core/include/Acts/Clusterization/Clusterization.hpp @@ -55,12 +55,14 @@ struct Connect2D { Connect2D() = default; explicit Connect2D(bool commonCorner) : conn8{commonCorner} {} virtual ConnectResult operator()(const Cell& ref, const Cell& iter) const; + virtual ~Connect2D() = default; }; // Default connection type for 1-D grids: 2-cell connectivity template struct Connect1D { virtual ConnectResult operator()(const Cell& ref, const Cell& iter) const; + virtual ~Connect1D() = default; }; // Default connection type based on GridDim @@ -71,12 +73,15 @@ struct DefaultConnect { }; template -struct DefaultConnect : public Connect1D {}; +struct DefaultConnect : public Connect1D { + virtual ~DefaultConnect() = default; +}; template struct DefaultConnect : public Connect2D { explicit DefaultConnect(bool commonCorner) : Connect2D(commonCorner) {} DefaultConnect() = default; + virtual ~DefaultConnect() = default; }; /// @brief labelClusters diff --git a/Core/include/Acts/Clusterization/TimedClusterization.hpp b/Core/include/Acts/Clusterization/TimedClusterization.hpp index b3e77f75604..93148db0671 100644 --- a/Core/include/Acts/Clusterization/TimedClusterization.hpp +++ b/Core/include/Acts/Clusterization/TimedClusterization.hpp @@ -28,6 +28,7 @@ struct TimedConnect : public Acts::Ccl::DefaultConnect { TimedConnect(Acts::ActsScalar time); TimedConnect(Acts::ActsScalar time, bool conn) requires(N == 2); + virtual ~TimedConnect() = default; virtual ConnectResult operator()(const Cell& ref, const Cell& iter) const override;