Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Docker definition for dev container #170

Closed
Pete-Y-CS opened this issue May 17, 2023 · 2 comments · Fixed by #194
Closed

Create Docker definition for dev container #170

Pete-Y-CS opened this issue May 17, 2023 · 2 comments · Fixed by #194
Assignees
@Pete-Y-CS

Comments

@Pete-Y-CS
Copy link
Contributor

Set up a dev container for us to run ATIP in a local container for development on DFT Windows laptops
@Pete-Y-CS
Copy link
Contributor Author

Have begun work on add-dev-container. There is a docker config which can be launched in codespaces, and if you use
node serve (npm install serve, npx serve dist) after building then the tool runs but unfortunately serve removes querystrings when redirecting URL (vercel/serve#643), which means selecting an authority with the tool doesn't work. You can manually acccess by directly adding /scheme?authority=York for example, though.

@robinlovelace-ate
Copy link
Contributor

👍 to this.

@Pete-Y-CS Pete-Y-CS self-assigned this May 22, 2023
@Pete-Y-CS Pete-Y-CS linked a pull request May 25, 2023 that will close this issue
Add dev container #194
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pete-Y-CS Pete-Y-CS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dev container acteng/atip
2 participants
@robinlovelace-ate @Pete-Y-CS