From d18d8f3476f9f7dbe76982e809ca1fd515d63d51 Mon Sep 17 00:00:00 2001 From: Gerhard Steenkamp Date: Mon, 30 Sep 2024 12:59:37 +0200 Subject: [PATCH 1/2] make integratorId optional in constructor --- packages/sdk/src/client.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/sdk/src/client.ts b/packages/sdk/src/client.ts index 4c3b2f7..5822c91 100644 --- a/packages/sdk/src/client.ts +++ b/packages/sdk/src/client.ts @@ -57,6 +57,7 @@ import { const CLIENT_DEFAULTS = { pollingInterval: 3_000, + integratorId: "PROTOCOL_XYZ", logLevel: "ERROR", } as const; @@ -65,7 +66,7 @@ export type AcrossClientOptions = { /** * An identifier representing the integrator. */ - integratorId: string; + integratorId?: string; /** * The chains to use for the Across API. Should be imported from `viem/chains`. */ @@ -179,7 +180,7 @@ export class AcrossClient { * @internal */ private constructor(args: AcrossClientOptions) { - this.integratorId = args.integratorId; + this.integratorId = args?.integratorId ?? CLIENT_DEFAULTS.integratorId; this.walletClient = args?.walletClient; this.publicClients = configurePublicClients( args.chains, From a4b2373ff8a362469c5a2473facb00ff09df2096 Mon Sep 17 00:00:00 2001 From: Gerhard Steenkamp Date: Mon, 30 Sep 2024 13:04:32 +0200 Subject: [PATCH 2/2] set default to sdk name for meaningful tracking --- packages/sdk/src/client.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sdk/src/client.ts b/packages/sdk/src/client.ts index 5822c91..e060a49 100644 --- a/packages/sdk/src/client.ts +++ b/packages/sdk/src/client.ts @@ -57,7 +57,7 @@ import { const CLIENT_DEFAULTS = { pollingInterval: 3_000, - integratorId: "PROTOCOL_XYZ", + integratorId: "INTEGRATOR_SDK", logLevel: "ERROR", } as const;