Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIM keybindings #3

Open
cviejo opened this issue Mar 17, 2021 · 5 comments
Open

VIM keybindings #3

cviejo opened this issue Mar 17, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@cviejo
Copy link

cviejo commented Mar 17, 2021

Looks fantastic. I'm going to go ahead and be that guy: VIM mode?

@keithwhor
Copy link
Contributor

Do you want to give me the key mappings?

CPHEditor.prototype.hotkeys = {

If you can create them for me in a gist I can add them as an option and refactor how hotkey mappings work. :)

@cviejo
Copy link
Author

cviejo commented Mar 18, 2021

Basic vim motions would not be difficult to implement but also very limited. A better approach might be to use something similar to monaco-vim. It takes the keybindings and vim mode from codemirror and maps them to the monaco api. I'll take a look at it on the weekend.

@keithwhor
Copy link
Contributor

Great. Let me know what you come up with and I can think about the best way to integrate it into the codebase!

@calebeaires
Copy link

Happy to see this being done. This is a good one!

@keithwhor
Copy link
Contributor

Hey @cviejo just wondering if you found the hotkey mappings? I can integrate support for the VIM key mappings on our next major release as long as somebody gives them to me in JSON format.

@keithwhor keithwhor added the enhancement New feature or request label Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants