Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Scir.cbrain_config stuff; add support for NCPU per tool config. #26

Open
prioux opened this issue Apr 13, 2015 · 2 comments
Open
Assignees
Labels
Admin Features or bugs related to administrative features Enhancement Priority: Normal

Comments

@prioux
Copy link
Member

prioux commented Apr 13, 2015

This structure was meant to hold info about
the default queue and extra qsub args, but instead
let's delegate the responsibility for those values
to the code that launches tasks using scir (in the case
of cbrain, ClusterTask's submit_cluster_job().

That way, we can substitute the ppn=N values from
the tool_config's ncpu attribute, if we agree for
a convention for it (e.g. if the bourreau's
cms_extra_qsub_args attribute contains something like

"-l node=1:ppn={NCPU}"

then submit_cluster_job() would make the substitution
before passing the string to the job object creator.

@prioux prioux added this to the 4.1.0 milestone Apr 13, 2015
@prioux prioux self-assigned this Apr 13, 2015
@prioux prioux modified the milestones: 4.1.0, 4.2.0 Aug 13, 2015
@prioux prioux modified the milestones: 4.2.0, 4.3.0 Nov 3, 2015
@natacha-beck natacha-beck modified the milestones: 4.3.0, 4.4.0 Mar 16, 2016
@natacha-beck natacha-beck modified the milestones: 4.4.0, 4.5.0 May 31, 2016
@prioux prioux modified the milestones: 4.5.0, 4.6.0 Aug 18, 2016
@natacha-beck natacha-beck modified the milestones: 4.6.0, 4.7.0 Nov 21, 2016
@prioux prioux modified the milestones: 4.7.0, 5.1.0 Apr 24, 2017
@prioux prioux modified the milestones: 5.1.0, 4.7.0 Apr 24, 2017
@prioux prioux modified the milestones: 5.1.0, 5.2.0 Nov 16, 2018
@prioux prioux modified the milestones: 5.2.0, 5.3.0 Sep 16, 2019
@natacha-beck
Copy link
Contributor

@prioux I see no reference to Scir.cbrain_config with ncpu.
We use Scir.cbrain_config for the following:

  • default_queue
  • amazon_ec2_access_key_id
  • amazon_ec2_secret_access_key
  • amazon_ec2_region
  • extra_qsub_args

Should all of this move to tool_config ?

@prioux
Copy link
Member Author

prioux commented Oct 9, 2019

No let me handle all that, there's a fundamental redesign of all this that need to be undertaken.

@prioux prioux modified the milestones: 5.3.0, 5.4.0 Dec 11, 2019
@prioux prioux added the Admin Features or bugs related to administrative features label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Features or bugs related to administrative features Enhancement Priority: Normal
Projects
None yet
Development

No branches or pull requests

2 participants