Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the log_params_changes() for boutiques tasks #1465

Open
prioux opened this issue Jan 31, 2025 · 0 comments
Open

Improve the log_params_changes() for boutiques tasks #1465

prioux opened this issue Jan 31, 2025 · 0 comments
Assignees
Labels
Admin Features or bugs related to administrative features Boutiques Boutiques integration Enhancement Priority: Normal User Interface

Comments

@prioux
Copy link
Member

prioux commented Jan 31, 2025

When CBRAIN a task is updated by a user and the user changes some of the params, the method log_params_changes() is called to make a 'pretty' log of what has changed. This happens in the update action in the tasks controller. The method was created a long time ago, well before we had tasks implemented through boutiques descriptors. The new boutiques tasks store all their params inside a single key in the params, the "invoke" structure. So the log_params_changes() is too dumb and when a single boutiques parameter changes it will report that the entire invoke structure has changed, with before and after.

We need to make the method 'aware' of the invoke structure, if present, and make it more intelligently report what has changed in it.

@prioux prioux added Admin Features or bugs related to administrative features Boutiques Boutiques integration Enhancement Priority: Normal User Interface labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Features or bugs related to administrative features Boutiques Boutiques integration Enhancement Priority: Normal User Interface
Projects
None yet
Development

No branches or pull requests

2 participants