Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporating adsorption structures into sl framework #22

Open
lancekavalsky opened this issue Oct 27, 2021 · 0 comments
Open

incorporating adsorption structures into sl framework #22

lancekavalsky opened this issue Oct 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@lancekavalsky
Copy link
Collaborator

At present the AutoCatDesignSpace (and by extension AutoCatSequentialLearner) has a 1:1 correspondence between a single structure and corresponding label. So currently only the clean structures are featurized to learn the binding energies that are provided via labels.

Moving forward there are a few potential options that could generalize this:

  1. Extend how structures are provided and stored to include the adsorbed structures instead of as a list of just directly supplying the ase.Atoms
    e.g. [{'substrate': ase.Atoms, 'adsorbed': OUTPUT_DICT_FROM_GENERATE_RXN_STRUCTURES}, {…}]
    or [{'substrate': ase.Atoms, 'adsorbed': ase.Atoms}, {…}]
  2. If the labels are going to be adsorption energies, then this is something that can be calculated internally given the ase.Atoms objects for both the adsorbed and clean structures (as well as user specified reference states) rather than as a separately supplied np.ndarray. This could then be placed within a corresponding adsorbed dictionary to be pulled as needed
  3. The downside of the above point is that it is arguably at the sacrifice of generalizability if the label is going to be something other than adsorption energies, e.g. d-band centers. (unless there is a clean way to allow for both approaches to coexist...)
@lancekavalsky lancekavalsky added the enhancement New feature or request label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant