-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Factors reporting #107
Comments
@MaJuRG Will our new Or might we want to retain that information for use in a future issue -- e.g., a CLI option the user can invoke to include this info in the JSON/CSV output -- storing it for now in some new Delta attributes like |
@johnmhoran We can add two additional flags; Feel free to make a ticket for specific that if you wish (no need if you want to include it in you current work) We will need to think about ways to record the license key (and maybe copyright holders), but for now we can record just the fact we have a license change as a flag. |
Excellent. Thanks, @MaJuRG . I'll include it in my current work rather than opening a new ticket. (I'm tackling issues #107, #109 and #110 together under the 107 rubric.) If I understand your reply, we won't be storing the current strings ( |
Yes, exactly. |
Thanks. |
For the file, we could follow the git file status:
And we also could use algorithm the git used to detect the file moved, renamed or copied. |
The current approach of listing multiple Factors in one column makes it difficult to sort and filter file-level data in the primary DeltaCode reporting tool - i.e. a spreadsheet. It would be better to reset to three separate fields for:
With these three as separate fields, a user can more easily choose the relevant combinations of file information. This does not deal with the actual detection of a changed copyright or license notice. Rather the idea is to show whether each file has copyright or license information. This assumes that we deprecate License Category reporting for now see #106
The text was updated successfully, but these errors were encountered: