From e47a23186f1ae9d040819056792afbcdccd7db8a Mon Sep 17 00:00:00 2001 From: Pavel Bychko Date: Sat, 25 Feb 2023 14:55:20 +0300 Subject: [PATCH 1/5] Set strict_types --- .php-cs-fixer.dist.php | 2 ++ src/CardServiceProvider.php | 2 ++ src/TotalCard.php | 2 ++ 3 files changed, 6 insertions(+) diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php index 6f049a0..80d9ad4 100644 --- a/.php-cs-fixer.dist.php +++ b/.php-cs-fixer.dist.php @@ -1,5 +1,7 @@ in([ __DIR__ . '/src' diff --git a/src/CardServiceProvider.php b/src/CardServiceProvider.php index 162980e..d4f61c2 100644 --- a/src/CardServiceProvider.php +++ b/src/CardServiceProvider.php @@ -1,5 +1,7 @@ Date: Sat, 25 Feb 2023 14:55:42 +0300 Subject: [PATCH 2/5] Update composer.json --- composer.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/composer.json b/composer.json index 08f10dd..e539a0f 100644 --- a/composer.json +++ b/composer.json @@ -21,11 +21,11 @@ }, "require-dev": { "friendsofphp/php-cs-fixer": "^3.0", - "nunomaduro/collision": "^5.0 || ^6.0", + "nunomaduro/collision": "^5.0 || ^6.0 || ^7.0", "nunomaduro/larastan": "^1.0 || ^2.0", - "orchestra/testbench": "^6.0 || ^7.0", + "orchestra/testbench": "^6.0 || ^7.0 || ^8.0", "phpstan/phpstan": "^1.0", - "phpunit/phpunit": "^9.5" + "phpunit/phpunit": "^9.6 || ^10.0" }, "minimum-stability": "dev", "prefer-stable": true, From f8a1b8bd032b1bec45c3f3427e734d75d03eb63c Mon Sep 17 00:00:00 2001 From: Pavel Bychko Date: Sat, 25 Feb 2023 14:56:33 +0300 Subject: [PATCH 3/5] Add issue template --- .github/ISSUE_TEMPLATE/bug.yml | 54 +++++++++++++++++++++++++++++++ .github/ISSUE_TEMPLATE/config.yml | 8 +---- 2 files changed, 55 insertions(+), 7 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/bug.yml diff --git a/.github/ISSUE_TEMPLATE/bug.yml b/.github/ISSUE_TEMPLATE/bug.yml new file mode 100644 index 0000000..8e16d7e --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug.yml @@ -0,0 +1,54 @@ +name: Bug Report +description: Report a general package issue. Filling in the issue template is mandatory, issues without it will be closed. +title: "[Bug]: " +labels: [ bug ] +body: + - type: checkboxes + id: terms + attributes: + label: Is the bug applicable and reproducible to the latest version of the package and hasn't it been reported before? + options: + - label: Yes, it's still reproducible + required: true + - type: input + attributes: + label: What version of Package are you using? + description: 'For example: 1.2.0' + validations: + required: true + - type: input + attributes: + label: What version of Laravel are you using? + description: 'For example: 9.52.0' + validations: + required: true + - type: input + attributes: + label: What version of Laravel Nova are you using? + description: 'For example: 4.22.1' + validations: + required: true + - type: input + attributes: + label: What version of PHP are you using? + description: 'For example: 8.1.0' + validations: + required: true + - type: textarea + attributes: + label: Describe your issue + description: Describe the problem you're seeing, Please be short, but concise. + validations: + required: true + - type: textarea + attributes: + label: How can the issue be reproduced? + description: Please provide easy-to-reproduce steps (repository, simple code example, failing unit test). + validations: + required: true + - type: textarea + attributes: + label: What should be the expected behaviour? + description: Please describe what the expected outcome should be. Any suggestions to what is wrong? + validations: + required: true diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 2b967dd..6009993 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -5,10 +5,4 @@ contact_links: about: Ask the community for help - name: Request a feature url: https://github.com/abordage/nova-total-card/discussions/new?category=ideas - about: Share ideas for new features - - name: Report a bug - url: https://github.com/abordage/nova-total-card/issues/new - about: Report a reproducible bug - - name: Report a security issue - url: https://github.com/abordage/nova-total-card/security/policy - about: Learn how to notify us for sensitive bugs \ No newline at end of file + about: Share ideas for new features \ No newline at end of file From e882f34016aead05d2f44de635cea417e2c1eb59 Mon Sep 17 00:00:00 2001 From: Pavel Bychko Date: Sat, 25 Feb 2023 14:56:54 +0300 Subject: [PATCH 4/5] Add PR template --- .github/PULL_REQUEST_TEMPLATE.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..8cd7b41 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,18 @@ +Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. + + +> 💡 Please take note of our [contributing guidelines](https://github.com/abordage/.github/blob/master/CONTRIBUTING.md) + +1. Why should it be added? What are the benefits of this change? +2. Does it contain multiple, unrelated changes? Please separate the PRs out. +3. Does it include tests, if possible? +4. Any drawbacks? Possible breaking changes? + +**Mark the following tasks as done:** +- [ ] Checked the codebase to ensure that your feature doesn't already exist. +- [ ] Take note of the contributing guidelines. +- [ ] Checked the pull requests to ensure that another person hasn't already submitted a fix. +- [ ] Added tests to ensure against regression. +- [ ] Updated the changelog + +### Thanks for contributing! From ba4e099734e93ce16c273bc1026f22eeeb7f3d39 Mon Sep 17 00:00:00 2001 From: Pavel Bychko Date: Sat, 25 Feb 2023 14:57:06 +0300 Subject: [PATCH 5/5] Update README --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index dc1b65b..016054b 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,5 @@ + + # Nova Total Card A Laravel Nova card that displays the total number of records for a specific model, or the number of records that matches a condition. @@ -33,7 +35,7 @@ A Laravel Nova card that displays the total number of records for a specific mod

## Requirements -- PHP 7.4 or higher +- PHP 7.4 - 8.2 - Nova 4 ## Installation