Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing Faraday #170

Open
mattheworiordan opened this issue Aug 12, 2018 · 2 comments
Open

Consider removing Faraday #170

mattheworiordan opened this issue Aug 12, 2018 · 2 comments

Comments

@mattheworiordan
Copy link
Member

mattheworiordan commented Aug 12, 2018

Removing Faraday will reduce the dependencies, but should also allow us to take a little more control over the underlying library.

See excon/excon#682 for example, something we should be able to resolve easily by changing settings, but this is not possible because of https://github.com/lostisland/faraday/blob/master/lib/faraday/adapter/excon.rb#L22-L24.

┆Issue is synchronized with this Jira Task by Unito

@mattheworiordan mattheworiordan added the enhancement New feature or improved functionality. label Aug 12, 2018
@ably-sync-bot ably-sync-bot changed the title Consider removing Faraday Consider removing Faraday Feb 5, 2021
@ably-sync-bot
Copy link

➤ Matthew O'Riordan commented:

This may no longer apply given #197 ( https://github.com/ably/ably-ruby/pull/197|smart-link )

@deanna-lad
Copy link

@mattheworiordan Do you think we should still remove Faraday? What benefit will this bring to the codebase?

@sync-by-unito sync-by-unito bot assigned ghost Jul 29, 2022
@ghost ghost removed their assignment Dec 6, 2022
@sync-by-unito sync-by-unito bot removed the enhancement New feature or improved functionality. label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants