New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tree-shakable `MessageInteractions` module #1397

Closed

owenpearson opened this issue Jul 18, 2023 · 3 comments

Assignees

Member

owenpearson commented Jul 18, 2023

depends on Create tree-shakeable BaseClient and Rest modules #1374 and Create tree-shakable RealtimeChannels and RealtimePresence modules #1393
create new MessageInteractions class
if provided to the BaseClient constructor, allows user to add filtered subscriptions

The text was updated successfully, but these errors were encountered:

sync-by-unito bot commented Jul 18, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3736

Collaborator

lawrence-forooghian commented Oct 25, 2023

@owenpearson explained today that there are multiple concepts of "filtered subscription". The one that this issue is talking about is the overload of RealtimeChannel#subscribe that accepts a MessageFilter.

lawrence-forooghian self-assigned this

lawrence-forooghian added a commit that referenced this issue


          Make subscription filtering tree-shakable

167dd6f

We expose a MessageIteractions module which allows users to pass a
MessageFilter object to RealtimeChannel’s `subscribe` and `unsubscribe`.

Resolves #1397.

lawrence-forooghian added a commit that referenced this issue


          Extract RealtimeChannel MessageFilter-related code to new class

948f255

In preparation for #1397 (making MessageFilter functionality
tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make subscription filtering tree-shakable

7c379cf

We expose a MessageIteractions module which allows users to pass a
MessageFilter object to RealtimeChannel’s `subscribe` and `unsubscribe`.

Resolves #1397.

lawrence-forooghian mentioned this issue

[SDK-3736] Make MessageFilter subscription filtering tree-shakable #1473

Merged

lawrence-forooghian added a commit that referenced this issue


          Extract RealtimeChannel MessageFilter-related code to new class

6978dc5

In preparation for #1397 (making MessageFilter functionality
tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make subscription filtering tree-shakable

53cafd4

We expose a MessageIteractions module which allows users to pass a
MessageFilter object to RealtimeChannel’s `subscribe` and `unsubscribe`.

Resolves #1397.

lawrence-forooghian added a commit that referenced this issue


          Extract RealtimeChannel MessageFilter-related code to new class

a622f22

In preparation for #1397 (making MessageFilter functionality
tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make subscription filtering tree-shakable

5c54465

We expose a MessageIteractions module which allows users to pass a
MessageFilter object to RealtimeChannel’s `subscribe` and `unsubscribe`.

Resolves #1397.

lawrence-forooghian added a commit that referenced this issue


          Extract RealtimeChannel MessageFilter-related code to new class

61cf994

In preparation for #1397 (making MessageFilter functionality
tree-shakable).

lawrence-forooghian added a commit that referenced this issue


          Make subscription filtering tree-shakable

6a96472

We expose a MessageIteractions module which allows users to pass a
MessageFilter object to RealtimeChannel’s `subscribe` and `unsubscribe`.

Resolves #1397.

Collaborator

lawrence-forooghian commented Nov 21, 2023

Closed in #1473.

lawrence-forooghian closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment