Request: Do not require quotes

[dander401]

Love this extension, and was hoping to use it for markdown editing as well as my angular development. Only problem is that definitions are not found unless the file path is in quotes... which breaks mark down links.

[abierbaum]

@dander401 I don't do any markdown editing with links. Can you suggest a change and test it out? I would definitely accept a pull request that adds support.

[dander401]

I don't know how to test changes to extensions in VS code, but it looks like it would be a change to reg ex on extension.ts line 99 would do the trick. Mark down links are surrounded by () so adding an or statement to the regex should do it

// We are looking for strings with filenames
// - simple hack for now we look for the string with our current word in it on our line
//   and where our cursor position is inside the string
// -- -- a simple extra or to the reg ex
let re_str = `\"(.*?${word}.*?)\"|\'(.*?${word}.*?)\'|\((.*?${word}.*?)\)`;
let match = line.text.match( re_str );

here is a function to maintain a list of the surrounded matches that might be a bit more manageable

// We are looking for strings with filenames
// - simple hack for now we look for the string with our current word in it on our line
//   and where our cursor position is inside the string
// -- -- a for loop to add extra pairs
function getWordRegEx( word: string ) {
    let i;
    let ret = '';
    // pairs of characters that will wrap a file path
    let terminatingChars: Array<Array<string>> = [
        [ '\"', '\"' ],
        [ '\'', '\'' ],
        [ '\(', '\)' ]
    ];
    // loop through each set of pairs, and or the regexs
    for ( i = 0; i < terminatingChars.length; i++ ) {
        if ( i > 0 ) {
            ret += '|';
        }
        let pair = terminatingChars[ i ];
        ret += `${pair[ 0 ]}(.*?${word}.*?)\"${pair[ 1 ]}`;
    }
    return ret;
}

let re_str = getWordRegEx( word );
let match = line.text.match( re_str );

If you can tell me a good way to test this, I'm cool doing it. Just let me know how I can help

[vrokolos]

can you please add support for double quotes for use in xml attributes and >< for use in xml elements?