Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCM Build Target or Build Instructions are incorrect #1880

Open
dgdguk opened this issue Dec 23, 2024 · 2 comments
Open

ROCM Build Target or Build Instructions are incorrect #1880

dgdguk opened this issue Dec 23, 2024 · 2 comments

Comments

@dgdguk
Copy link

dgdguk commented Dec 23, 2024

It seems that at some point the build target for ROCM was renamed from HIPBLAS to HIP. I'm not sure if this was inadvertent or deliberate, but either way, the build instructions for ROCM are incorrect. The README says to use:

CMAKE_ARGS="-DGGML_HIPBLAS=on" pip install llama-cpp-python

However, to successfully build ROCM, the command is actually:

CMAKE_ARGS="-DGGML_HIP=on" pip install llama-cpp-python

This is obviously a fairly trivial fix, but I haven't created a PR as I'm not sure if it's the docs or the build target name that is incorrect.

@fat-tire
Copy link

See PR 1867.

@dgdguk
Copy link
Author

dgdguk commented Dec 23, 2024

OK - this can obviously be closed once the PR is merged.

Also maybe worth updating the bug reporting instructions to also include checking in the PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants