Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete qmp class #8

Open
abbbi opened this issue Jan 30, 2022 · 2 comments
Open

Remove obsolete qmp class #8

abbbi opened this issue Jan 30, 2022 · 2 comments

Comments

@abbbi
Copy link
Owner

abbbi commented Jan 30, 2022

The qemu agent client still uses the qmp class as shipped, it should be possible to use qemu.qmp library for the agent communication, too. negotiate option must be set to false, ..

@abbbi abbbi closed this as completed Jan 30, 2022
@abbbi abbbi reopened this Feb 4, 2022
abbbi added a commit that referenced this issue Feb 4, 2022
@abbbi
Copy link
Owner Author

abbbi commented Feb 9, 2022

Current qemu.qmp implementation has troubles with older qemu agents, the execute() function might hang forever
if the qemu agent does not support the qmp execution IDs:

https://gitlab.com/jsnow/qemu/-/issues/62

only way would be to use the not exposed ._raw() function with assign_id=False, but i think ill just wait until
qemu.qmp is fixed in that regard.

@jnsnow
Copy link

jnsnow commented Mar 4, 2022

working on it, apologize for the slowness here. There's a bit of work to do in order to extract the library out from qemu.git so that patches can be contributed faster and more smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants