Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user-pointer and equal #26

Open
tromey opened this issue Nov 3, 2015 · 3 comments
Open

user-pointer and equal #26

tromey opened this issue Nov 3, 2015 · 3 comments

Comments

@tromey
Copy link
Collaborator

tromey commented Nov 3, 2015

It seems to me that two user-pointer objects should be equal if they wrap the same pointer and have the same finalizer.
@aaptel
Copy link
Owner

aaptel commented Nov 4, 2015

Sounds good to me.

@aaptel
Copy link
Owner

aaptel commented Nov 4, 2015

The next step would be for the user to provide its own equal test function, but that opens a whole new can of worms.

@tromey
Copy link
Collaborator Author

tromey commented Nov 4, 2015

I think a custom equal function should only be done when it's possible to add new types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tromey @aaptel