Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and fix CI/CD pipeline #338

Closed
maxRN opened this issue Aug 21, 2024 · 1 comment
Closed

Update and fix CI/CD pipeline #338

maxRN opened this issue Aug 21, 2024 · 1 comment

Comments

@maxRN
Copy link
Contributor

maxRN commented Aug 21, 2024

The pipeline doesn't run and is using outdated actions (avms/setup-ocaml@v2 was superseded by the official ocaml/setup-ocaml action).

We can copy some of the setup from how dune does it: https://github.com/ocaml/dune/blob/main/.github/workflows/workflow.yml

I'm currently working on a possible implementation here: #337

@aantron
Copy link
Owner

aantron commented Aug 21, 2024

Thanks! I've got a parallel PR in #335 doing some of the same things, though my plan was to work on it slowly. You're welcome to pull in commits from it and I'll merge the whole thing together with due credit. In particular, I have the build working on recent versions, see the two commits there (8d0bd88, c9db203).

CI: test only on OCaml 4.13 and higher

Dream no longer installs on lower OCaml versions, because mirage-crypto
requires OCaml 4.13. See

  https://github.com/mirage/mirage-crypto/pull/233

The reason for mirage-crypto requiring 4.13 seems to be minor
convenience, and isn't justified in my opinion. However, Dream itself
will likely require OCaml 5 in the medium term due to upgrading to
multicore and effects, so it seems unnecessary to make an effort to
restore 4.08 support at this point.
Exclude dream-mirage.opam from main CI

dream-mirage has additional dependencies that may be slower to update,
or otherwise cause package conflicts. It's only needed for the mirage
test, not for the main test suite of Dream.

@aantron aantron closed this as completed in d3cb68b Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants