Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn on network.ipv4_address (and network.ipv6_address) #31

Open
dnephin opened this issue Dec 8, 2016 · 1 comment
Open

warn on network.ipv4_address (and network.ipv6_address) #31

dnephin opened this issue Dec 8, 2016 · 1 comment

Comments

@dnephin
Copy link
Collaborator

dnephin commented Dec 8, 2016

ipv4/6_address are not supported by swarmkit yet, but we don't warn when they are included in a file.

cc @aanand @vdemeester

@dnephin
Copy link
Collaborator Author

dnephin commented Dec 8, 2016

I started working on this in master...dnephin:warn-on-ipv4addr, but it's unfortunately a lot more complicated than it sounds.

We're comparing against the raw config types, so trying to access these nested fields is not easy. We don't even know the structure of the networks value, it could be a list of a map.

I think this code would be easier if we iterated over the reflect.Value instead of the types.Dict. We could even store the "unsupported" fields as struct tags instead of a separate list.

@dnephin dnephin assigned dnephin and unassigned dnephin Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant