Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple issues with dependencies #3

Closed
a6a3uh opened this issue Jul 26, 2018 · 9 comments
Closed

Multiple issues with dependencies #3

a6a3uh opened this issue Jul 26, 2018 · 9 comments
Assignees
Labels
bug minor A minor issue

Comments

@a6a3uh
Copy link

a6a3uh commented Jul 26, 2018

It seems like dependencies listed in requirements.txt are not enough. At least on Mac OSX. And probably on any clean system.

What I did to make some progress (I used conda) is as follows:

conda create --name kucher2 python=3.6 --no-default-packages

source activate kucher2

conda install pyqt

conda install numpy

conda install pytest

conda install pyserial

pip install quamash

conda install cython

pip install construct

And finally stuck with popcop missing or not working (producing Assert on import) if just plain copied with issue described here.

Fixing that by just commenting line causing assertion I get to next issue with missing import in popcop.

@pavel-kirienko
Copy link
Member

pavel-kirienko commented Jul 26, 2018

Yes, requirements.txt requires updating; I'm going to keep this open for now.

@pavel-kirienko pavel-kirienko self-assigned this Jul 26, 2018
@pavel-kirienko pavel-kirienko added bug minor A minor issue labels Jul 26, 2018
@a6a3uh
Copy link
Author

a6a3uh commented Jul 27, 2018

I see quamash is a submodule dependency so could not be installed separately. Or could be removed from submodules. The same is for construct. It's submodule version is compatible with application while the latest one is not.

@a6a3uh
Copy link
Author

a6a3uh commented Jul 27, 2018

Btw. While app is running in python 3.6.6. With python 3.7.0 it gives

Traceback (most recent call last):
File "./zubax-kucher", line 22, in
sys.exit(main())
File "... kucher/kucher/main.py", line 45, in main
from quamash import QEventLoop
File "... kucher/kucher/libraries/quamash/quamash/init.py", line 275
future = asyncio.async(future, loop=self)
^
SyntaxError: invalid syntax

@pavel-kirienko
Copy link
Member

The stack trace you posted is incomplete.

@a6a3uh
Copy link
Author

a6a3uh commented Jul 27, 2018

Sorry. Updated the message with full stack trace.
Editor removes indentation. Actually arrow is pointing on async word.

@pavel-kirienko
Copy link
Member

Ah. Here is the culprit: https://docs.python.org/3.6/library/asyncio-task.html#asyncio.async. async is a reserved keyword starting with Python 3.7; that API function is deprecated since Python 3.4. I should update quamash to a newer version where this issue is fixed - this changeset was merged in just 4 days ago and is released under v0.6.1: https://github.com/harvimt/quamash/pull/94/files#diff-b6196c9cf4a2f8190164136b76096c05L275

@pavel-kirienko
Copy link
Member

If you're keen on Python 3.7, perhaps you could submit a PR updating the quamash submodule? That would be appreciated.

@irieblue
Copy link

irieblue commented Nov 6, 2018

I am interested in getting this running on OSX. I am willing to help out. What is the latest on supporting OSX. Is there a recommended minimum version of python to target?

@pavel-kirienko
Copy link
Member

Is there a recommended minimum version of python to target?

Yes, Kucher requires Python 3.6. Let me know if you have further questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug minor A minor issue
Projects
None yet
Development

No branches or pull requests

3 participants