From 3599550e74a6133e70a363f0a5e8ebc876fecf0a Mon Sep 17 00:00:00 2001 From: Akhilesh Halageri Date: Sun, 9 Jun 2024 17:38:00 +0000 Subject: [PATCH] fix(tests): use firestore bemulator for run cli tets --- tests/conftest.py | 3 +++ tests/unit/cli/test_cli.py | 10 +++++----- zetta_utils/constants.py | 2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index 5fe896756..311815055 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -5,6 +5,9 @@ import pytest import docker +from zetta_utils import constants + +constants.RUN_DATABASE = None def pytest_addoption(parser): diff --git a/tests/unit/cli/test_cli.py b/tests/unit/cli/test_cli.py index ce22f1a26..9b8a30573 100644 --- a/tests/unit/cli/test_cli.py +++ b/tests/unit/cli/test_cli.py @@ -25,7 +25,7 @@ def register_dummy(): {"@type": "dummy", "i": {"a": "b"}}, ], ) -def test_zetta_run(spec, register_dummy, mocker, datastore_emulator): +def test_zetta_run(spec, register_dummy, mocker, firestore_emulator): mocker.patch("zetta_utils.parsing.cue.load", return_value=spec) runner = CliRunner() @@ -50,7 +50,7 @@ def test_show_registry(register_dummy): {"@type": "dummy", "i": {"a": "b"}}, ], ) -def test_zetta_run_str(spec, register_dummy, mocker, datastore_emulator): +def test_zetta_run_str(spec, register_dummy, mocker, firestore_emulator): mocker.patch( "fsspec.open", side_effect=[tempfile.TemporaryFile(mode="w"), tempfile.TemporaryFile(mode="w")], @@ -67,14 +67,14 @@ def test_zetta_run_str(spec, register_dummy, mocker, datastore_emulator): SPEC_WITH_CUSTOM_IMPORT = {"@type": "registered_in_file"} -def test_zetta_run_extra_import_fail(tmp_path, datastore_emulator): +def test_zetta_run_extra_import_fail(tmp_path, firestore_emulator): runner = CliRunner() # make sure that it doesn't run without a file import should_fail = runner.invoke(cli.run, ["-s", json.dumps(SPEC_WITH_CUSTOM_IMPORT)]) assert should_fail.exit_code != 0 -def test_zetta_run_extra_import_success(tmp_path, mocker, datastore_emulator): +def test_zetta_run_extra_import_success(tmp_path, mocker, firestore_emulator): mocker.patch( "fsspec.open", side_effect=[tempfile.TemporaryFile(mode="w"), tempfile.TemporaryFile(mode="w")], @@ -88,7 +88,7 @@ def test_zetta_run_extra_import_success(tmp_path, mocker, datastore_emulator): assert should_succeed.exit_code == 0 -def test_zetta_run_extra_import_py_check_fail(tmp_path, datastore_emulator): +def test_zetta_run_extra_import_py_check_fail(tmp_path, firestore_emulator): runner = CliRunner() my_file = tmp_path / "custom_import" my_file.write_text(CUSTOM_IMPORT_CONTENT) diff --git a/zetta_utils/constants.py b/zetta_utils/constants.py index 8a298d67e..ec7e5822f 100644 --- a/zetta_utils/constants.py +++ b/zetta_utils/constants.py @@ -1,4 +1,4 @@ """Common project-wide constants.""" DEFAULT_PROJECT = "zetta-research" -RUN_DATABASE = "run-db" +RUN_DATABASE: str | None = "run-db"