Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up config.php to clarify use #288

Open
prodigion opened this issue Nov 11, 2021 · 0 comments
Open

Split up config.php to clarify use #288

prodigion opened this issue Nov 11, 2021 · 0 comments

Comments

@prodigion
Copy link

Currently, config.php has configuration parameters, reads configuration from an environment file, validates configuration, and has sql transaction code. These should be mostly split to separate files to separate what users should/shouldn't touch.

Default configuration could go in a separate file (/includes/DefaultSettings.php), with site-specific configuration could go in its own file (LocalSettings.php). Or put it all in the database. It shouldn't rely on environment variables or .env files

Any logic should be moved to a separate file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant