-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add post, absent and confirmed ballots to results.csv, results table #43
Comments
Fixing this will affect raw data to results.csv transformation. It might also affect the data model. |
@maciej not sure we had this in the original data. Will check back. |
@mihi-tr yes, they are there |
@maciej would you want them to be treated similarly to parties? E.g. have a line for each of them? |
@mihi-tr I'm not sure if I understand you. |
@maciej in the cleaned data we have each polling-station-party combination as a row - would you just want a row with the missing, invalid etc. as well? or shall I include this simply in the polling station data (right now it get's removed afair). |
@mihi-tr OK, I'd say I want a single row for a (Party, ElectionUnit, NonPollingStationVotes) tuple. |
The POST, ABSENT and CONFIRMED votes are available only with election unit granularity. We do have those results data broken by municipality, not to mention by polling station The implications of that are far reaching. The current system design – all the way from the data representation, through the result endpoints up to the presentation layer – assumes that every result is assigned to a municipality. Fixing this issue will not be trivial and will require redesign work for all the layers of the system. |
hey people, this might sound a bit naive, but I have also discussed it with Please do let me know what do you think would it be solvable this way and Best, On Sun, Oct 12, 2014 at 2:41 AM, Maciej Biłas [email protected]
|
Hey @darkobrkan, |
Sorry for dumping out of the discussion - was quite busy with trainings and changing work (yes I'm not working with School of Data anymore). I can work cleaning this probably on the WE. Did we get the new results yet? |
@mihi-tr hey Michael! |
@mihi-tr looks good. I haven't verified the data, but I assume it's correct. Sadly, for the time being we also need a fake municipality_id for every electoral_unit. |
Do you want to introduce them? Or shall I? e.g. 999 998 997 |
@mihi-tr I think it's better if you do it, because then the Google Refine settings/scripts will reflect all processed CSVs. Please layout the file in terms of columns it the same way as results.csv are. Then again, if it's a hassle in Refine – no big deal, it's trivial in Pandas. |
Adresses #43 on github. The format now follows the results format. The following mock Municipality IDs have been created: 997 post 998 absent 999 confirmed
@maciej take a look now - once we're done I'll also add the refine .json protocol. |
This is the header of "General-Election-Results-2010.csv":
For some reason it contains a candidate column, which I think was supposed to refer to a candidate name – something we never had data for. Without it the data won't import. Since the column in the MySQL table and our results.csv file it's trivial to remove I've added a task for that #47. I'll look into that later this week and reimport the |
The new data is out. There is though one change that might be problematic. As for the data gathering, we could probably get the data in the same On Mon, Oct 27, 2014 at 1:13 AM, Maciej Biłas [email protected]
|
@darkobrkan, I've created a separate issue for looking into the 2014 data. It's here: #48. |
@maciej what is the status on this? |
Hey @mihi-tr I'm swamped with my day job work currently. I cannot tell you when I'll be able to look at this. Perhaps during the weekend I'll regenerate enough to look at code. |
@mihi-tr I've restarted working on this. I should give you some updates before end of the weekend. I've looked at the updated |
The post, absent and confirmed votes are now imported. |
Results currently ignore post (POŠTOM), absent (ODUSTVO) and confirmed and (POTVRÐENI) ballots.
The text was updated successfully, but these errors were encountered: