Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very long party abbreviation #25

Open
drewbo opened this issue Sep 4, 2014 · 11 comments
Open

Very long party abbreviation #25

drewbo opened this issue Sep 4, 2014 · 11 comments
Assignees

Comments

@drewbo
Copy link
Contributor

drewbo commented Sep 4, 2014

@darkobrkan

Looks like the party, HRVATSKA KOALICIJA HDZ 1990 - HSP BIH , is being abbreviated as "HK HDZ 1990 - HSP BIH". Is there any way we can shorten that to save some screen real-estate? Maybe to HDZ 1990?

@darkobrkan
Copy link
Contributor

Well the best you could do to make it still accurate is "HDZ1990-HSP" That
works?

On Thu, Sep 4, 2014 at 8:19 PM, Drew Bollinger [email protected]
wrote:

Assigned #25 #25 to
@darkobrkan https://github.com/darkobrkan.


Reply to this email directly or view it on GitHub
#25 (comment).

@informationchef
Copy link
Contributor

There were many party entries that didn't seem especially legibly abbreviate-able, and I believe the default in the processing was to just put the full party name into the abbreviation field.

@drewbo
Copy link
Contributor Author

drewbo commented Sep 4, 2014

Thanks @darkobrkan, that works. The only other one I found that causes issues is "NSRZ, KSPP, E-5 I LDS - ZZUSK" for NS R ZA BOLJITAK, KSPP, E-5 I LDS - ZAJEDNO ZA USK.

Can someone change this in the database as well? Thanks all for the input

@maciej
Copy link
Contributor

maciej commented Sep 4, 2014

Here is a list of longest abbreviations, sorted by string length (it's a quick thing I've done, so it counts the strings by bytes, not actual length in the encoding):

"HSP DRAS – P21S"
"KP GDS BIH I NEP BIH"
"HK HDZ 1990 - HSP BIH"
"NSRZ, KSPP, E-5 I LDS - ZZUSK"
"SDU BIH - LDS BIH - E5 - KZTK"
"ROSO VIKTOR - NEOVISNI KANDIDAT"
"СЛзаСА ПДП-СДС-ДП"
"HERCEG STIPE - NEOVISNI KANDIDAT"
"SOLDO TOMISLAV - NEOVISNI KANDIDAT"
"DRAGOJE SMILJAN - NEOVISNI KANDIDAT"
"HODŽIĆ HAZIM - NEZAVISNI KANDIDAT"
"ĆURKOVIĆ STIPO - RADE - NEOVISNI KANDIDAT"
"ТОМИЋ МИЛОШ - НЕЗАВИСНИ КАНДИДАТ"
"ШАКОТИЋ АНЂЕЛКО - НЕЗАВИСНИ КАНДИДАТ"

I hope it helps.

@mihi-tr
Copy link
Contributor

mihi-tr commented Sep 9, 2014

@informationchef is right - some of them were not abbreviated. Also some are multi-party coalitions. This makes stuff really hard. But it's bosnia right - did you think this was easy?

@kulinba
Copy link

kulinba commented Sep 9, 2014

Some of them are independent candidates with their full names and names of
a coalition. It makes it hard to abbreviate to something understandable.
This is the reason why I didn't abbreviate that. Maybe we can just use
abbreviation IC and name initials? that would make it 4 letter abbrev. but
no one would know who that person is.

On Tue, Sep 9, 2014 at 10:49 AM, Michael Bauer [email protected]
wrote:

@informationchef https://github.com/informationchef is right - some of
them were not abbreviated. Also some are multi-party coalitions. This makes
stuff really hard. But it's bosnia right - did you think this was easy?


Reply to this email directly or view it on GitHub
#25 (comment).

@drewbo
Copy link
Contributor Author

drewbo commented Sep 9, 2014

Luckily the other ones mentioned by @maciej don't actually appear as any of the winners (I think).

If we can get 'NS R ZA BOLJITAK, KSPP, E-5 I LDS - ZAJEDNO ZA USK' shortened we should be in business from a display standpoint

@darkobrkan
Copy link
Contributor

We could use probably just "Zajedno za USK" in this case, as far as I am
concerned :) it will not be a mistake

On Tue, Sep 9, 2014 at 3:48 PM, Drew Bollinger [email protected]
wrote:

Luckily the other ones mentioned by @maciej https://github.com/maciej
don't actually appear as any of the winners (I think).

If we can get 'NS R ZA BOLJITAK, KSPP, E-5 I LDS - ZAJEDNO ZA USK'
shortened we should be in business from a display standpoint


Reply to this email directly or view it on GitHub
#25 (comment).

@drewbo
Copy link
Contributor Author

drewbo commented Sep 19, 2014

@maciej or @mihi-tr can you make the two changes to fix the ones that appear in the portal?

  • "HDZ1990-HSP"
  • "Zajedno za USK"

@maciej
Copy link
Contributor

maciej commented Sep 21, 2014

Party abbreviations are pulled in from the prepared data CSVs.
I think it's best if @mihi-tr changes the source data for the General-Election-Results-2010.csv. Once done, I'll reimport the data to the DB.

@maciej maciej assigned mihi-tr and unassigned darkobrkan Sep 21, 2014
@informationchef
Copy link
Contributor

This seems like something we'll want repeatable for the viewability of the upcoming election data. I'm happy to add an "abbreviations" permanent table and a quick script job post-load that applies known additional abbreviations to any loaded data that includes these two party abbreviations to start, and we can add others that impact the visual site as-needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants