-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] New Firmware v10 bulbs aren't being added to HomeBridge #140
Comments
Hey, thanks for reporting the bug and the very detailed report. A couple questions:
A few troubleshooting options:
Let me know how the above suggestions work out. Thank you. edit: grammar |
|
That actually looks to have worked. With alpha last week I was crashing on startup, which doesn't appear to be happening now which is good. All 7 of my bulbs, including the 3 on v10 were discovered and are showing in accessories now. I am however seeing the issue that richie was seeing in #138 where if you use the dimmer it makes the bulbs unresponsive in home. No crashing though, just that bulb is no longer usable. |
I was not observing that the bulbs become unresponsive but instead that they were being set as "off" if the plugin didn't receive a response fast enough. Is that what you were observing? I have updated the alpha to alpha.4 which removes the somewhat overzealous setting bulbs to offline. Keep in mind that this version is still somewhat bug prone and possibly missing features. Let me know how it works for you however. |
I think alpha.4 is mostly working. I've experienced some weird things since moving to it, but as you've said that's maybe to be expected.
Overall it's loss of functionality and buggy like you've said, but working ok-ish at least for now. I know you mentioned that this release wont go to production for some time while you work towards feature parity and solving bug issues, but I'm curious if there's any chance of the changes you made to get v10 firmware working being made to the previous version. This is assuming 2.0.0 is a full rewrite of some kind seeing as you're needing to bring feature parity up to par. I can understand if that's not feasible, but figured it was worth asking. I'm also willing to help test to the best of my ability and to near the end of my wife's patience :) Here are the logs for item number 3 if you wanted to see them. edit: And thank you for all your help with this. More support than I often see from the vendors I work with as an IT Pro |
Thank you very much for the detailed response. The change to allow the new v10 bulbs is literally 1 line change. The difficulty will be that I'm not entirely certain which version of the source code I used or if I even can find it. This is due to disorganization in the past where my release versions didn't necessary reflect changes in source. I will resolve this one of two ways and attempt to do so this weekend.
I'll update here once that change has been made. At which point you should restore from your 1.9.9 version and update to 1.9.10 (once released). Thanks for the praise and look forward to getting this working for you soon. Oh and thank you for the continued logs. |
I have made the relevant changes and published version 1.9.10 as latest. If you are restoring from a Homebridge backup, please install version 1.9.10 or disable Homebridge Magichome before loading the backup. Otherwise upon restart version 2.0.0-alpha.4 will convert your Homebridge Magichome accessories. If you are loading from a docker image backup then simply update to version 1.9.10 and restart. Please let me know the results of this. |
Gave 1.9.10 a try with my backed up files and I seem to be having the same original issue. The new V10 devices don't show up. I do find it curious that it only finds a single existing device though, as there are 3 others that show within homebridge as well. Here's an example of one of them not being shown in the log. edit: added further info |
I ran another test since I've got everything backed up as it is. I tried completely clearing out the plugin and reinstalling fresh to see if that would behave any differently. The same bulb was the only one to show back up, which honestly makes me think something else might be going on that's keeping me from getting the new bulbs in since I can't even get the other 3 that were working previously to register from scratch again. There was a new warning from the plugin this time, but I'm not sure if it's a big deal or not. I wasn't getting it before. I'm tempted to start completely from scratch and see if that changes anything for me, but I know it'll mean resetting up (naming and placing in rooms) all of my devices at least one more time, more like a couple. With 20+ devices in homebridge it'll take some time, but if you think that's where we're at let me know and I'll give that a go. |
Please do not update from scratch if you had it working before. I personally know how long that takes and I don't believe that will solve anything for now. When you say that it only finds a single device, do you mean that the other 20 devices do not load correctly? In your logs I only see 1 device being registered. Alternatively, do you mean that the 20 old devices are loading correctly and in addition 1 v10 device is registering but not the 3 other v10 devices? Whatever you do, please keep that backup handy. I will look into this further but I am honestly perplexed at the logs. Please let me know if the other devices are being loaded correctly in v1.9.10. |
I have updated to v1.9.11 with some extra logging: If you could, in the configs please set your logging level to 5 as shown below and then restart. Then let's take a look at the output. I've added logging to show exactly what we are getting back from the bulbs.
|
Here's The output from the logs. I've not looked at these too closely yet, but there were some red errors, so maybe we're getting somewhere. As for previous questions. When I boot up like this with the configs that were previously working, I get 4/7 bulbs, these are the older models and not the new ones with firmware v10. As for the 20 devices, a lot of those are from other plugins and all come in just fine. If I wipe out the magichome plugin and try to let these bulbs pull in from scratch, the one names Ali's Nightstand is the only one that shows up in the accessories, the same as we were seeing in the logs. All of the bulbs in the image above, including the Ali's nightstand are the v7 bulbs. |
Wait, the new bulbs just showed up, just had to wait a bit longer after the initial boot. I'd mentioned this in my first post that I often had to do this, but I've been being impatient with it tonight it seems. I'll do some testing and see how things are working out here. I'm still curious about the logs not showing all of the devices registering, but not as concerned if things work for me here. |
Best I can tell, everything is as functional as it was before. Those three bulbs are in a scene together and siri will often trigger the scene but not manage to get all 3 on for some reason. This isn't new behavior though, was happening with the old bulbs too. I'm thinking this can be closed, but do let me know if there is anything worth acting on in the last logs I sent over. Thank you again for all your work on this! |
Logs
homebridge.log
Describe the bug
I setup a couple of new light bulbs in magic home last night and they've not been added to homebridge after 3 reboots and 12+ hours now. Sometimes my devices take some time to show up, it's always been that way, but generally by now they'd have been added.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Based on the configs, and documentation, new devices should be added on the first reboot of the server, or within the rescan period from your configs.
"This plugin automatically detects MagicHome bulbs and controllers just like the Magichome app, and it should do so when you first run Homebridge. No more setting individual IP addresses per device."
"Rescan the network for new devices every 30 seconds."
Additional context
These bulbs are new to me, I'd had different brands in the past, but they work as expected in the same way withing MagicHome. The only difference I noted is that they're running a V10 firmware where the previous ones were running v7.
Host Hardware
Homebridge and MagicHome
Screenshots
https://cdn.discordapp.com/attachments/138409093131010048/1149695818312458301/image.png
https://cdn.discordapp.com/attachments/138409093131010048/1149695962688782377/image.png
https://cdn.discordapp.com/attachments/138409093131010048/1149711383852744734/image.png
https://cdn.discordapp.com/attachments/138409093131010048/1149711709951504464/image.png
The text was updated successfully, but these errors were encountered: