Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZF2EdgeTest: methods 'getPaymentMeansCode()' & 'getPaymentMeansInformation()' does not override super methods #653

Open
FrankHossfeld opened this issue Jan 8, 2025 · 4 comments · May be fixed by #654

Comments

@FrankHossfeld
Copy link

Trying to build the latest version locally fails due to an issue in the ZF2EdgeTest-class. The methods getPaymentMeansCode()& getPaymentMeansInformation()does not override super methods.

To fix the issue, delete both methods (line 277 - 285).

@ThomasChr
Copy link
Contributor

Do all tests still run without any problems on your end when simply deleting the methods?
If so, I will just delete them and make a PR.

@FrankHossfeld
Copy link
Author

Yes, all tests run with no errors.

Both methods are implemented twice. Once inside the inner class DebitPayment which is correct and then also in the ZF2EdgeTest it selfs, which is a problem because the class self nor there super classes extends IZUGFeRDTradeSettlementDebit.

@ThomasChr ThomasChr linked a pull request Jan 8, 2025 that will close this issue
@ThomasChr
Copy link
Contributor

PR done. Sorry for the wrong methods. Should have seen them when running the tests.

@FrankHossfeld
Copy link
Author

np ... thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants