Newguns megathread.

[MistakeNot4892]

Will add/remove from this as I fix 'em.

• Variable laser cannot fire taser shots
• Lasers use gunshot sound
• Can't tell if the breech is open from examine.
• Load fail due to open breech has no feedback
• Fire fail due to open breech has no feedback
• Precision laser cannot fire.
• Breech loading rifles eject their shells when firing, is this desirable?
• Loading magazines does not chamber a round automatically.
• Removing magazines removes chambered rounds.
• Revolver has pink grip.
• burst laser shotgun can't fire
• laser cannon can't fire
• dropped guns remain (wielded)
• autocannon does not accept a magazine
• shotgun pump has no feedback
• .45 SMG can be reloaded from an ammo box.
• 9mm magazine does not exist.
• 5.7mm magazine/ammo do not exist.
• 45 mag does not exist.
• Capgun ammo does not exist.
• variable caliber lasers begin with the incorrect caliber set.
• Speedloaders use empty icon_state always.
• Magazine icons do not update based on current ammo.

[comma]

Double-barelled shotgun implementation fails with weirdness.
Chamber is child of /breech/ with max_shots set to 2 and to HOLD_CASINGS, and with firemodes.

/obj/item/gun_component/chamber/ballistic/breech/shotgun
    icon_state="shotgun_double"
    weapon_type = GUN_SHOTGUN
    max_shots = 2
    handle_casings = HOLD_CASINGS
    load_method = SINGLE_CASING

    firemodes = list(
        list(mode_name="fire one barrel at a time", burst=1, fire_delay=0, burst_accuracy=null, dispersion=null),
        list(mode_name="fire both barrels at once", burst=2, fire_delay=null, move_delay=5, burst_accuracy=null, dispersion=null),
        )

1.Open breech
2.Load two shells
3.Close breech.
4.Shoot. One bullet will fly out on any firemode.

Third shell appears, staying in chambered. You can unload two shells, one or two of which will be spend depending on firemode. Examining shows there's a shell left inside, but you can't get it, it claims gun is empty. VV shows it's not spent (at least desc), but you still can't fire it. It's in chambered var.

[MistakeNot4892]

Leave this up in case more bugs appear.

[comma]

Speedloaders use empty icon_state always

[comma]

Cannot VV guns with names starting with . like ".357 revolver"

[MistakeNot4892]

Cannot reproduce, with and without \improper.

http://i.imgur.com/HOkoM4g.png

[MistakeNot4892]

I'm dumb, forgot the other issues.

[MistakeNot4892]

#419