Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCP_CHECK_PROFILE: correct way to 'bypass' a check #241

Closed
geor-g opened this issue Jan 3, 2024 · 1 comment · Fixed by #242
Closed

DCP_CHECK_PROFILE: correct way to 'bypass' a check #241

geor-g opened this issue Jan 3, 2024 · 1 comment · Fixed by #242

Comments

@geor-g
Copy link

geor-g commented Jan 3, 2024

Given a profile like this:

DCP_CHECK_PROFILE = {
    'criticality':
        {
            'check_assets_am_volindex_one': 'ERROR',
            'check_assets_cpl_missing_from_multi_cpl': 'ERROR',
            'check_assets_cpl_missing_from_vf': 'ERROR',
            'check_link_ov_asset': 'ERROR',
            'check_picture_cpl_archival_framerate': 'WARNING',
            'check_picture_cpl_hfr_framerate': 'WARNING',
            'check_subtitle_cpl_duplicated_uuid': 'WARNING',
            'check_subtitle_cpl_editrate': 'WARNING',
            'check_subtitle_cpl_empty': 'WARNING',
            'check_subtitle_cpl_font_size': 'WARNING',
            'check_subtitle_cpl_font': 'WARNING',
            'check_subtitle_cpl_loadfont': 'WARNING',
            'check_subtitle_cpl_xml': 'WARNING',
            'check_subtitle_dcp_format': 'WARNING',
            'check_*_bitrate': 'WARNING',
            'check_*_hash': 'ERROR',
            'default': 'INFO'
        },
        'bypass': [
            'check_dcp_multiple_am_or_vol'
        ]
}

I still see check_dcp_multiple_am_or_vol in the checks array, and bypass set tofalse:

       {
          "name": "check_dcp_multiple_am_or_vol",
          "pretty_name": "Only one AssetMap and VolIndex shall be present.",
          "doc": " Only one AssetMap and VolIndex shall be present.\n\n            References: N/A\n        ",
          "bypass": false,
          "seconds_elapsed": 0.000021696090698242188,
          "asset_stack": [
            "REDACTED"
          ],
          "errors": [
            {
              "name": "",
              "pretty_name": "",
              "doc": "",
              "message": "Missing VolIndex file",
              "criticality": "INFO"
            }
          ]
        }

Is this expected, possibly due to improper use of default: INFO as per above? If so, what's the correct way to handle this?

Thanks so much for your work on Clairmeta -- it's a great tool!

Clairmeta: 1.5.0

@remia
Copy link
Collaborator

remia commented Jan 13, 2024

Hi @geor-g,

What you are doing is correct, you have indeed found a bug, I'll push a fix for it thanks for reporting!

@remia remia linked a pull request Jan 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants