From 858d8c3c1de26ee394fc5bb93d40e28429c68907 Mon Sep 17 00:00:00 2001 From: Naren Dasan Date: Thu, 30 Jul 2020 17:28:31 -0700 Subject: [PATCH] fix(Windows)!: Fix dependency resolution for local builds BREAKING CHANGE: Users on Windows trying to use cuDNN 8 must manually configure third_party/cudnn/local/BUILD to use cuDNN 8. Signed-off-by: Naren Dasan Signed-off-by: Naren Dasan --- third_party/cudnn/local/BUILD | 2 +- third_party/tensorrt/local/BUILD | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/third_party/cudnn/local/BUILD b/third_party/cudnn/local/BUILD index 8c3983731b..6332213822 100644 --- a/third_party/cudnn/local/BUILD +++ b/third_party/cudnn/local/BUILD @@ -26,7 +26,7 @@ cc_import( name = "cudnn_lib", shared_library = select({ ":aarch64_linux": "lib/aarch64-linux-gnu/libcudnn.so", - ":windows": glob(["bin/cudnn64_*.dll"])[0], + ":windows": "bin/cudnn64_7.dll", #Need to configure specific version for windows "//conditions:default": "lib/x86_64-linux-gnu/libcudnn.so", }), visibility = ["//visibility:private"], diff --git a/third_party/tensorrt/local/BUILD b/third_party/tensorrt/local/BUILD index e512a36f22..3a9b8b2710 100644 --- a/third_party/tensorrt/local/BUILD +++ b/third_party/tensorrt/local/BUILD @@ -72,7 +72,6 @@ cc_import( cc_library( name = "nvinfer", - srcs = select({ ":windows": [ "lib/nvinfer.lib" ] }), deps = [ "nvinfer_headers", "nvinfer_lib",