Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array param without const #3

Open
jaclas opened this issue Aug 14, 2018 · 4 comments
Open

Array param without const #3

jaclas opened this issue Aug 14, 2018 · 4 comments

Comments

@jaclas
Copy link

jaclas commented Aug 14, 2018

Why in many BaseX interfaces/classes you don't use a const for array param, like this:

function Encode(data: TBytes): TBaseNcodingString; override;

It has a big impact on performance.
See:
https://www.delphitools.info/2010/07/28/all-hail-the-const-parameters/

@Xor-el
Copy link
Owner

Xor-el commented Aug 14, 2018

@jaclas , thanks for the nice observation.
as you may have noticed, this library has not received any code updates recently because I have been busy with other projects.
while I may make some improvements to this library in the near future, I suggest you take a look at SimpleBaseLib4Pascal, (if it covers your needs). this is actively worked on and has received much love than BaseNcodingPascal.

@jaclas
Copy link
Author

jaclas commented Aug 14, 2018

Thanks for hint about SimpleBaseLib4Pascal, I switch to use this lib.
As this lib is obsolete, maybe worth to add this info to description?

@Xor-el
Copy link
Owner

Xor-el commented Aug 14, 2018

@jaclas , well I wouldn't come to the conclusion that this Lib is obsolete for now just that no current improvements are being made at the moment.

@jaclas
Copy link
Author

jaclas commented Aug 14, 2018

Ok, sorry for misunderstanding. I thought that since there is a new BaseXX coding library, the previous one is already dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants