Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MP3 support #5

Open
richardwesthaver opened this issue May 4, 2022 · 3 comments
Open

Add MP3 support #5

richardwesthaver opened this issue May 4, 2022 · 3 comments
Assignees

Comments

@richardwesthaver
Copy link

richardwesthaver commented May 4, 2022

Looks like libsndfile recently got mp3 support - libsndfile/libsndfile#258

The release on homebrew doesn't have it last time I checked but you can verify it's working by installing from source.

Any chance of adding to the supported formats of this library in the near future? happy to help with/test the implementation.

sample output:

> sndfile-info ~/mpk/tracks/mp3/luke_vibert-yamahorns.mp3

========================================
File : /Users/ellis/mpk/tracks/mp3/luke_vibert-yamahorns.mp3
Length : 7880842
Found 'ID3' marker.
  ID3v2.4 header length :	2185
----------------------------------------
MPEG-1/2 Audio
----------------------------------------
  MPEG version   : MPEG 1.0
  layer          : 3
  rate           : 44100
  mode           : joint stereo
  mode ext       : 0
  framesize      : 1044
  crc            : 0
  copyright flag : 0
  private flag   : 0
  original flag  : 1
  emphasis       : 0
  bitrate mode   : constant
  bitrate        : 320 kbps
ID3v1 Tags
  Title       : yamahorns
  Artist      : luke vibert
  Album       : voix des reason
  Year        : 2007
  Comment     :
ID3v2 Tags
  TIT2        : yamahorns
  TPE1        : luke vibert
  TRCK        : 673/999
  TALB        : voix des reason
  TDRC        : 2007
  COMM        : (ID3v1 Comment)[engCOMM] flac 1.1.2

----------------------------------------
Sample Rate : 44100
Frames      : 8682114
Channels    : 2
Format      : 0x00230082
Sections    : 1
Seekable    : TRUE
Duration    : 00:03:16.873
Signal Max  : 33052.7 (0.08 dB)
@tuxzz
Copy link
Member

tuxzz commented May 4, 2022

Yay! They finally added MP3 support!
Thank you for the notice. I will check more details once I have free time.

@tuxzz tuxzz self-assigned this May 4, 2022
@hmijail
Copy link

hmijail commented Jul 17, 2022

Also volunteering to help with whatever. In fact, if it's going to take long, maybe I can try to do it myself.

@tuxzz
Copy link
Member

tuxzz commented Jul 17, 2022

Also volunteering to help with whatever. In fact, if it's going to take long, maybe I can try to do it myself.

Thank you for your interest in this project.

I'm sorry but in fact I have no much free time since a long time ago. It would be great if you could contribute to this project. Make a PR once it's finished and I will take a review on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants