Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tokenizer method signature #250

Open
mh-northlander opened this issue Nov 28, 2024 · 1 comment · Fixed by #254
Open

Update Tokenizer method signature #250

mh-northlander opened this issue Nov 28, 2024 · 1 comment · Fixed by #254
Milestone
0.8

Comments

@mh-northlander
Copy link
Collaborator

mh-northlander commented Nov 28, 2024 •
edited
Loading

Currently some Tokenizer methods return MorphemeList. Update them to List<Morpheme>.

Return type should be specific i.e. MorphemeList, and argument type should be general i.e. List.
@mh-northlander mh-northlander added this to the 0.8 milestone Nov 28, 2024
@mh-northlander mh-northlander mentioned this issue Nov 28, 2024
Merged
@mh-northlander mh-northlander linked a pull request Nov 28, 2024 that will close this issue
Deprecate tokenizeSentences #254
Merged
@mh-northlander
Copy link
Collaborator Author

We want to hide MorphemeList from outside.

Let's add Tokenizer.split(List<Morpheme>, mode) to replace MorphemeList.split(mode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

Deprecate tokenizeSentences WorksApplications/Sudachi
1 participant
@mh-northlander