Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream dictionary entries #248

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Stream dictionary entries #248

merged 7 commits into from
Nov 28, 2024

Conversation

mh-northlander
Copy link
Collaborator

resolve #244.

Add Stream<Morpheme> entries() method to Dictionary.

  • User can use entries().iterator() and entries().spliterator() if needed

Also change Lexicon.wordIds method.

  • Change return type from the internal class Ints to Integer.
  • Remove dictionary id argument and make it iterate over all lexicons in it.

@mh-northlander mh-northlander added this to the 0.8 milestone Nov 27, 2024
@mh-northlander mh-northlander linked an issue Nov 27, 2024 that may be closed by this pull request
Iterate over all entries in the dictionary #244
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mh-northlander mh-northlander merged commit 9c43b13 into develop-v0.8 Nov 28, 2024
4 checks passed
@mh-northlander mh-northlander deleted the feature/244-iterate-entries branch November 28, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuma-t kazuma-t kazuma-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.

Iterate over all entries in the dictionary
2 participants
@mh-northlander @kazuma-t