Force saving a playground via Query API #2037
Comments
brandonpayton
added a commit
that referenced
this issue
Dec 5, 2024
…#2059) ## Motivation for the change, related issues We want to be able to address specific Playgrounds via slug, even if the addressed Playground does not yet exist. We'd rather not presume and store a Playground in a user's browser storage without their consent, so as a compromise, we can prompt the user and let them choose whether to store a site with the specified slug. Related to #2037 cc @akirk ## Implementation details This PR adds support for a `if-stored-site-missing=prompt` query param that can be used alongside a `site-slug=<slug>` query param. If both params are provided and a site with the specified slug does not exist, we prompt the user and ask what they would like to do.  ## Testing Instructions (or ideally a Blueprint) - Run the dev server with `npm run dev` - Visit http://127.0.0.1:5400/website-server/?if-stored-site-missing=prompt&site-slug=speed-build-challenge - Confirm the modal displays and test that each button does as expected Note that when choosing to continue with the temporary site, it is currently intentional that the original query params are not cleared. The reason is that if we are wanting to target an specific, possibly-non-existent slug, perhaps the user should be prompted with each page refresh. --------- Co-authored-by: Adam Zieliński <[email protected]> Co-authored-by: Bero <[email protected]>
|
@akirk, is the following PR enough to resolve this issue? |
|
It is enough, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With #1561, the ability to arbitrarily add a site-slug to the URL was removed. Thus, every new playground is a temporarily one and it has to be saved deliberately. What would be a way to ensure it is saved? A potential way to do this is to re-add site creation to the
site-slugURL parameter. Or we could respond to asite-slugURL parameter to show a dialog like suggested in #2035 with the option to cancel.The text was updated successfully, but these errors were encountered: